You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/07 18:51:58 UTC
[jira] [Commented] (BEAM-664) Port Dataflow SDK WordCount
walkthrough to Beam site
[ https://issues.apache.org/jira/browse/BEAM-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729567#comment-15729567 ]
ASF GitHub Bot commented on BEAM-664:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1536
[BEAM-664] Revise WindowedWordCount example to be more independent of runner and execution style
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This removes the use of BigQuery from the WindowedWordCount example, replacing it with a somewhat hacky file-based write of the output, using the window as the idempotency key. In order to port the test and to benefit from recent improvements in `FileBasedCheckSumMatcher`, I've factored out the resiliency code from that into an internal-only minimal `ShardedFile` class with just enough API surface to write these tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam WindowedWordCount
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1536.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1536
----
commit bac7b192c9fefdf536e324f1fde73bac2cd903fa
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-11-04T03:44:45Z
Add IntervalWindow coder to the standard registry
commit aa09449379dfaedbdfb0b73bae85ffd334b838b1
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-11-03T21:37:26Z
Revise WindowedWordCount for runner and execution mode portability
commit 357732efb866e4a24d76a9aaafa10e6bc964fe7e
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-11-08T06:06:00Z
Check the onSuccessMatcher in DirectRunner if isBlockOnRun is set
commit 76d19716829cb98c4f0d4b34244fde8866b6d6a9
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-12-05T22:32:12Z
Factor out ShardedFile from FileChecksumMatcher
----
> Port Dataflow SDK WordCount walkthrough to Beam site
> ----------------------------------------------------
>
> Key: BEAM-664
> URL: https://issues.apache.org/jira/browse/BEAM-664
> Project: Beam
> Issue Type: Task
> Components: website
> Reporter: Hadar Hod
> Assignee: Hadar Hod
>
> Port the WordCount walkthrough from Dataflow docs to Beam website.
> * Copy prose (translate from html to md, remove Dataflow references, etc)
> * Add accurate "How to Run" instructions for each of the WC examples
> * Include code snippets from real examples
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)