You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/16 01:17:47 UTC
[GitHub] [geode] DonalEvans commented on a change in pull request #5225: GEODE-8217: Do not leave serialized bytes in DeltaSession
DonalEvans commented on a change in pull request #5225:
URL: https://github.com/apache/geode/pull/5225#discussion_r440530600
##########
File path: extensions/geode-modules-test/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionJUnitTest.java
##########
@@ -195,6 +199,65 @@ public void serializeReturnsSerializedObject() throws IOException {
assertThat(result).isEqualTo(serializedObj);
}
+ @Test
+ public void setDeserializedAttributesValueInvokesGetAttribute() {
+ when(manager.getPreferDeserializedForm()).thenReturn(true);
+ DeltaSession session = spy(new DeltaSession(manager));
+ String attributeName = "name";
Review comment:
This string is already defined as a field in the class, so may not need to be defined again here.
##########
File path: extensions/geode-modules-test/src/main/java/org/apache/geode/modules/session/catalina/callback/SessionExpirationCacheListenerJUnitTest.java
##########
@@ -41,4 +44,20 @@ public void TestAfterDestroyProcessesSessionExpiredByGemfire() {
verify(session).processExpired();
}
+
+ @Test
+ public void TestAfterDestroyProcessesSessionDestroyed() {
Review comment:
This method name should start with a lower-case t.
##########
File path: extensions/geode-modules-test/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionJUnitTest.java
##########
@@ -195,6 +199,65 @@ public void serializeReturnsSerializedObject() throws IOException {
assertThat(result).isEqualTo(serializedObj);
}
+ @Test
+ public void setDeserializedAttributesValueInvokesGetAttribute() {
+ when(manager.getPreferDeserializedForm()).thenReturn(true);
+ DeltaSession session = spy(new DeltaSession(manager));
+ String attributeName = "name";
+ List<String> attributeList = new ArrayList<>();
+ attributeList.add(attributeName);
+ Enumeration<String> attributeNames = Collections.enumeration(attributeList);
+ doReturn(attributeNames).when(session).getAttributeNames();
+ doReturn(new Object()).when(session).getAttribute(attributeName, false);
+
+ session.setDeserializedAttributesValue();
+
+ verify(session).getAttribute(attributeName, false);
+ }
+
+ @Test
+ public void setDeserializedAttributesValueNotInvokeGetAttributeIfNotPreferDeserializedForm() {
+ when(manager.getPreferDeserializedForm()).thenReturn(false);
+ DeltaSession session = spy(new DeltaSession(manager));
+ String attributeName = "name";
Review comment:
This string is already defined as a field in the class, so may not need to be defined again here.
##########
File path: extensions/geode-modules-test/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionJUnitTest.java
##########
@@ -195,6 +199,65 @@ public void serializeReturnsSerializedObject() throws IOException {
assertThat(result).isEqualTo(serializedObj);
}
+ @Test
+ public void setDeserializedAttributesValueInvokesGetAttribute() {
+ when(manager.getPreferDeserializedForm()).thenReturn(true);
+ DeltaSession session = spy(new DeltaSession(manager));
+ String attributeName = "name";
+ List<String> attributeList = new ArrayList<>();
+ attributeList.add(attributeName);
Review comment:
This can be replaced with:
`Collection<String> attributeList = Collections.singelton(attributeName);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org