You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/02/17 13:12:45 UTC

Review Request 56786: Hive view 2.0 upload table feature does not show error notifications when errors occurs during the process.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56786/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-20064
    https://issues.apache.org/jira/browse/AMBARI-20064


Repository: ambari


Description
-------

added notification in upload table feature.


Diffs (updated)
-----

  contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 8df03e5 
  contrib/views/hive20/src/main/resources/ui/app/mixins/ui-logger.js 277f69c 
  contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js a9bf9ea 
  contrib/views/hive20/src/main/resources/ui/app/services/alert-messages.js a05fc7a 
  contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs e4388f0 

Diff: https://reviews.apache.org/r/56786/diff/


Testing
-------

manual testing done.


Thanks,

Nitiraj Rathore


Re: Review Request 56786: Hive view 2.0 upload table feature does not show error notifications when errors occurs during the process.

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56786/#review166064
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 17, 2017, 1:12 p.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56786/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2017, 1:12 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20064
>     https://issues.apache.org/jira/browse/AMBARI-20064
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> added notification in upload table feature.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 8df03e5 
>   contrib/views/hive20/src/main/resources/ui/app/mixins/ui-logger.js 277f69c 
>   contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js a9bf9ea 
>   contrib/views/hive20/src/main/resources/ui/app/services/alert-messages.js a05fc7a 
>   contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs e4388f0 
> 
> Diff: https://reviews.apache.org/r/56786/diff/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>


Re: Review Request 56786: Hive view 2.0 upload table feature does not show error notifications when errors occurs during the process.

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56786/#review165943
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 17, 2017, 1:12 p.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56786/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2017, 1:12 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20064
>     https://issues.apache.org/jira/browse/AMBARI-20064
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> added notification in upload table feature.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 8df03e5 
>   contrib/views/hive20/src/main/resources/ui/app/mixins/ui-logger.js 277f69c 
>   contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js a9bf9ea 
>   contrib/views/hive20/src/main/resources/ui/app/services/alert-messages.js a05fc7a 
>   contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table.hbs e4388f0 
> 
> Diff: https://reviews.apache.org/r/56786/diff/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>