You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/10/30 10:06:44 UTC
[GitHub] smithsz opened a new pull request #128: Pass request agent to
cloudant-follow
smithsz opened a new pull request #128: Pass request agent to cloudant-follow
URL: https://github.com/apache/couchdb-nano/pull/128
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
Pass custom request agent through to cloudant-follow.
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
## Testing recommendations
Change includes an additional assert in the unit tests to ensure the `httpAgent` is passed correctly.
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## GitHub issue number
Minor change only.
<!-- If this is a significant change, please file a separate issue at:
https://github.com/apache/couchdb-nano/issues
and include the number here and in commit message(s) using
syntax like "Fixes #472" or "Fixes apache/couchdb#472". -->
## Related Pull Requests
Porting fix from [cloudant-nano](https://github.com/cloudant-labs/cloudant-nano/pull/15).
<!-- If your changes affects multiple components in different
repositories please put links to those pull requests here. -->
## Checklist
- [x] Code is written and works correctly;
- [x] Changes are covered by tests;
- [x] Documentation reflects the changes;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services