You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by se...@apache.org on 2014/09/23 23:49:42 UTC

[5/6] git commit: Remove error message in execution graph for concurrent state changes that are fully acceptable.

Remove error message in execution graph for concurrent state changes that are fully acceptable.


Project: http://git-wip-us.apache.org/repos/asf/incubator-flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-flink/commit/ab0b3a31
Tree: http://git-wip-us.apache.org/repos/asf/incubator-flink/tree/ab0b3a31
Diff: http://git-wip-us.apache.org/repos/asf/incubator-flink/diff/ab0b3a31

Branch: refs/heads/master
Commit: ab0b3a314c6b306300748826289944c028dbedc1
Parents: 6bd4d2c
Author: Stephan Ewen <se...@apache.org>
Authored: Tue Sep 23 20:49:39 2014 +0200
Committer: Stephan Ewen <se...@apache.org>
Committed: Tue Sep 23 20:49:39 2014 +0200

----------------------------------------------------------------------
 .../org/apache/flink/runtime/executiongraph/ExecutionGraph.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/ab0b3a31/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java b/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
index 9576a64..07e2455 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
@@ -372,7 +372,10 @@ public class ExecutionGraph {
 			int nextPos = nextVertexToFinish;
 			if (nextPos >= verticesInCreationOrder.size()) {
 				// already done, and we still get a report?
-				LOG.error("Job entered finished state a repeated time.");
+				// this can happen when:
+				// - two job vertices finish almost simultaneously
+				// - The first one advances the position for the second as well (second is in final state)
+				// - the second (after it could grab the lock) tries to advance the position again
 				return;
 			}