[jira] [Work logged] (TS-4900) con_id member variable is shadowed in Http2ClientSession

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-4900?focusedWorklogId=29874&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29874 ]

ASF GitHub Bot logged work on TS-4900:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Sep/16 01:29
            Start Date: 28/Sep/16 01:29
    Worklog Time Spent: 10m 
      Work Description: GitHub user shinrich opened a pull request:

    https://github.com/apache/trafficserver/pull/1055

    TS-4900: Http2ClientSession object leaks.

    There were returns in the middle of handlers.  When taken the object recursion count would not go to zero and the object would not be lost.
    
    This needs to go with the fix for TS-4813.  Otherwise, the system will crash before you see the leak.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shinrich/trafficserver ts-4900-pr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1055.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1055
    
----
commit 2c3c47dfe386a358f30ba8bf267ed86df2bbe7ba
Author: Susan Hinrichs <sh...@ieee.org>
Date:   2016-09-28T01:26:41Z

    TS-4900: Http2ClientSession object leaks.

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 29874)
            Time Spent: 10m
    Remaining Estimate: 0h

> con_id member variable is shadowed in Http2ClientSession
> --------------------------------------------------------
>
>                 Key: TS-4900
>                 URL: https://issues.apache.org/jira/browse/TS-4900
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP/2
>            Reporter: Susan Hinrichs
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Noticed this while tracking down another bug.  The debug messages were including the con_id value which was always null even through the ProxyClientSession class atomic increments to create a new value on new_connection.
> The member variable con_id is declared in both the parent class (ProxyClientSession) and the child class (Http2ClientSession).  Aside from debugging the con_id member variable doesn't really seem to be used for Http2, so this isn't a critical bug.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)