[jira] [Comment Edited] (CASSANDRA-5385) IndexHelper.skipBloomFilters won't skip non-SHA filters

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637673#comment-13637673 ] 

Jonathan Ellis edited comment on CASSANDRA-5385 at 4/21/13 10:50 PM:
---------------------------------------------------------------------

Ah, I see.  So, my assertions are correct for 1.2, which is what I've been working in lately.  I'll make sure it stays that way as I merge CASSANDRA-5497 and CASSANDRA-5492 forward.
                
      was (Author: jbellis):
    Ah, I see.  So, my assertions are correct for 1.2, which is what I've been working in lately.  I'll make sure it stays that way as I merge CASSANDRA-5492 forward.
                  
> IndexHelper.skipBloomFilters won't skip non-SHA filters
> -------------------------------------------------------
>
>                 Key: CASSANDRA-5385
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5385
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 2.0
>            Reporter: Carl Yeksigian
>            Assignee: Carl Yeksigian
>             Fix For: 1.2.4, 2.0
>
>         Attachments: 5385.patch, 5385-v2.patch
>
>
> Currently, if the bloom filter is not of SHA type, we do not properly skip the bytes. We need to read out the number of bytes, as happens in the Murmur deserializer, then skip that many bytes instead of just skipping the hash size. The version needs to be passed into the method as well, so that it knows what type of index it is, and does the appropriate skipping.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira