[jira] [Comment Edited] (CASSANDRA-11930) Range tombstone serialisation between 2.1 and 3.0 nodes (in 3.0 -> 2.1 direction) is broken for some Thrift deletions

["Tyler Hobbs (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313032#comment-15313032 ] 

Tyler Hobbs edited comment on CASSANDRA-11930 at 6/3/16 4:20 PM:
-----------------------------------------------------------------

Patch and pending CI runs:

||branch||testall||dtest||
|[CASSANDRA-11930-3.0|https://github.com/thobbs/cassandra/tree/CASSANDRA-11930-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11930-3.0-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11930-3.0-dtest]|
|[CASSANDRA-11930-3.7|https://github.com/thobbs/cassandra/tree/CASSANDRA-11930-3.7]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11930-3.7-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11930-3.7-dtest]|
|[CASSANDRA-11930-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-11930-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11930-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11930-trunk-dtest]|

Dtest PR that reproduces the issue (and can reproduce the ordering problem described above, but ignores it for now): https://github.com/riptano/cassandra-dtest/pull/1016


was (Author: thobbs):
Patch and pending CI runs:

||branch||testall||dtest||
|[CASANDRA-11930-3.0|https://github.com/thobbs/cassandra/tree/CASANDRA-11930-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASANDRA-11930-3.0-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASANDRA-11930-3.0-dtest]|
|[CASANDRA-11930-3.7|https://github.com/thobbs/cassandra/tree/CASANDRA-11930-3.7]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASANDRA-11930-3.7-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASANDRA-11930-3.7-dtest]|
|[CASANDRA-11930-trunk|https://github.com/thobbs/cassandra/tree/CASANDRA-11930-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASANDRA-11930-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASANDRA-11930-trunk-dtest]|

Dtest PR that reproduces the issue (and can reproduce the ordering problem described above, but ignores it for now): https://github.com/riptano/cassandra-dtest/pull/1016

> Range tombstone serialisation between 2.1 and 3.0 nodes (in 3.0 -> 2.1 direction) is broken for some Thrift deletions
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11930
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11930
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Coordination
>            Reporter: Aleksey Yeschenko
>            Assignee: Tyler Hobbs
>             Fix For: 3.0.x, 3.x
>
>
> {{LegacyLayout.LegacyRangeTombstoneList::serialize()}} has a broken assumption that a range tombstone implies {{CompositeType}}. This is incorrect, as you can have non-{{CompositeType}} range tombstones created via Thrift in 2.1, and as such wrapping {{clusteringComparator.subtypes()}} in a {{CompositeType}} is incorrect. On 2.1/2.2 side, when decoding the range tombstone list, {{RangeTombstoneList::deserialize()}} will use the raw type to decode start and end bounds, which will end up being confused by the extra 2 bytes in the beginning (short length) plus end of component header in the end.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)