You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kaxil (via GitHub)" <gi...@apache.org> on 2024/01/07 12:19:45 UTC
[PR] Add Airflow logo to the README [airflow]
kaxil opened a new pull request, #36645:
URL: https://github.com/apache/airflow/pull/36645
Similar to Apache Superset, adding this repo to README so that Airflow repo shows up nicely with thumbnails on various Topics pages like https://github.com/topics/airflow
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880071661
> The logo is not served from README :-( You need to be repo admin, go to repo settings and there add a "Social preview" image.
Are you sure about that? Most of the repos I am seeing they have the logo in README. Apache Superset is also a Apache project and they have nothing in there `.asf.yaml`. Maybe it just takes few hours to show up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880152013
> The image though is probably not perfect (refreshed preview in LinkedIn - Facebook is similar).
In the github docs (https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/customizing-your-repositorys-social-media-preview) they propose a resolution of 1280 by 640 pixels. Currently we have transparent background but in dark mode it looks a bit strange. Quote:
```
When using an image with transparency, keep in mind how it may look on different color backgrounds or platforms that don't support transparency.
Tip: If you aren't sure, we recommend using an image with a solid background.
```
Github also provides a template and they recommend having 40 pixels border around the content:
Shall we request another update? Is it helpful if I stitch a new logo image? Or anybody better in Gimp?
Mhm, before too much of discussion, here my non-transparent Gimp attempt:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880062687
I assume we _could_ set it manually but a follow-up weekend activity was to check if there is an option in `.asf.yaml` or maybe a feature needs to be added there to define it programatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880075252
Created this ticket - https://issues.apache.org/jira/browse/INFRA-25351 for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880074340
Yup found the Superset thing - [here](https://issues.apache.org/jira/browse/INFRA-20803?jql=text%20~%20%22social%20preview%22), we could request the same.
And we should make it self-serve via `.asf.yaml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880062299
The logo is not served from README :-(
You need to be repo admin, go to repo settings and there add a "Social preview" image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880079809
Yeah.. I'v already added a feature there - it's Python based so it's not a rocket science https://github.com/apache/infrastructure-p6/pull/1740. - we just need to check if there is an API in GitHub that we could use for that.
The only **small** problem with it that there are no tests for it .... so .... you have to **believe** it works 😱
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880058362
It didn't work; I will check the README files in the other repositories
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880160364
We have more logos at https://github.com/apache/airflow/tree/main/docs/apache-airflow/img/logos
If you'd like to take a stab, go for it @jscheffl . If not, I can ask one of our Frontend or designer folks at Astronomer to help out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880083915
> Created this ticket - https://issues.apache.org/jira/browse/INFRA-25351 for now
Oh, they already added it - that was FAST. Problem solved for now :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880118253
The image though is probably not perfect (refreshed preview in LinkedIn - Facebook is similar).
<img width="1416" alt="Screenshot 2024-01-07 at 18 22 37" src="https://github.com/apache/airflow/assets/595491/6d121782-2a67-48be-8803-4e457e58e911">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala merged PR #36645:
URL: https://github.com/apache/airflow/pull/36645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880073879
You are probably right, I experimented with another repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Airflow logo to the README [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #36645:
URL: https://github.com/apache/airflow/pull/36645#issuecomment-1880082614
> You are probably right, I experimented with another repo
@kaxil I was not fast enough with response... Yes I also tried with a temporary repo which was empty yesterday... from which I made the screenshot in Slack...
I was stuck in other weekend work, such I was not able to check `asf.yaml`or propose a feature - but if nobody else is faster, I still have it on my list the next days :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org