[GitHub] [iceberg] SinghAsDev commented on a diff in pull request #5036: Fix concurrent transactions overwriting commits by adding hive lock heartbeats.

[GitBox <gi...@apache.org>]

SinghAsDev commented on code in PR #5036:
URL: https://github.com/apache/iceberg/pull/5036#discussion_r936088986


##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreTest.java:
##########
@@ -41,10 +44,21 @@ public abstract class HiveMetastoreTest {
 
   @BeforeClass
   public static void startMetastore() throws Exception {
+    startMetastore(Collections.emptyMap());
+  }
+
+  public static void startMetastore(Map<String, String> hiveConfOverride) throws Exception {
     HiveMetastoreTest.metastore = new TestHiveMetastore();
-    metastore.start();
+    HiveConf hiveConfWithOverrides = new HiveConf(new Configuration(), TestHiveMetastore.class);

Review Comment:
   Not really, I just moved this line from `TestHiveMetastore`. Updated to remove this though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org