You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/05/16 02:57:21 UTC

Review Request: Fixed scheduler driver to call disconnected() when master fails over.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11191/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Description
-------

See summary.


This addresses bug MESOS-469.
    https://issues.apache.org/jira/browse/MESOS-469


Diffs
-----

  src/sched/sched.cpp a55329488ae886f76fdf4576050cdeb5ead8026b 
  src/tests/fault_tolerance_tests.cpp 68cd5fcff266d102d8edf265776517aa2eef6061 
  src/tests/master_tests.cpp 1b062d9ce96ae223389dea5f030f51640511ad52 

Diff: https://reviews.apache.org/r/11191/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request: Fixed scheduler driver to call disconnected() when master fails over.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11191/
-----------------------------------------------------------

(Updated May 23, 2013, 10:55 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

benh's. nnfr.


Description
-------

See summary.


This addresses bug MESOS-469.
    https://issues.apache.org/jira/browse/MESOS-469


Diffs (updated)
-----

  src/sched/sched.cpp a55329488ae886f76fdf4576050cdeb5ead8026b 
  src/tests/fault_tolerance_tests.cpp 68cd5fcff266d102d8edf265776517aa2eef6061 
  src/tests/master_tests.cpp 1b062d9ce96ae223389dea5f030f51640511ad52 

Diff: https://reviews.apache.org/r/11191/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request: Fixed scheduler driver to call disconnected() when master fails over.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11191/#review20952
-----------------------------------------------------------

Ship it!



src/sched/sched.cpp
<https://reviews.apache.org/r/11191/#comment43228>

    Let's wrap this in 'if (connected)' too so we don't do multiple Scheduler::disconnected.


- Benjamin Hindman


On May 23, 2013, 5:59 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11191/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 5:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> This addresses bug MESOS-469.
>     https://issues.apache.org/jira/browse/MESOS-469
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp a55329488ae886f76fdf4576050cdeb5ead8026b 
>   src/tests/fault_tolerance_tests.cpp 68cd5fcff266d102d8edf265776517aa2eef6061 
>   src/tests/master_tests.cpp 1b062d9ce96ae223389dea5f030f51640511ad52 
> 
> Diff: https://reviews.apache.org/r/11191/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request: Fixed scheduler driver to call disconnected() when master fails over.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11191/
-----------------------------------------------------------

(Updated May 23, 2013, 5:59 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

rebase


Description
-------

See summary.


This addresses bug MESOS-469.
    https://issues.apache.org/jira/browse/MESOS-469


Diffs (updated)
-----

  src/sched/sched.cpp a55329488ae886f76fdf4576050cdeb5ead8026b 
  src/tests/fault_tolerance_tests.cpp 68cd5fcff266d102d8edf265776517aa2eef6061 
  src/tests/master_tests.cpp 1b062d9ce96ae223389dea5f030f51640511ad52 

Diff: https://reviews.apache.org/r/11191/diff/


Testing
-------

make check


Thanks,

Vinod Kone