You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/10/18 11:36:05 UTC
[GitHub] [lucenenet] NightOwl888 opened a new pull request, #696: SWEEP: Add a nested comment explaining why this method is empty.
NightOwl888 opened a new pull request, #696:
URL: https://github.com/apache/lucenenet/pull/696
Fixes #681.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 merged pull request #696: SWEEP: Add a nested comment explaining why this method is empty.
Posted by GitBox <gi...@apache.org>.
NightOwl888 merged PR #696:
URL: https://github.com/apache/lucenenet/pull/696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on a diff in pull request #696: SWEEP: Add a nested comment explaining why this method is empty.
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on code in PR #696:
URL: https://github.com/apache/lucenenet/pull/696#discussion_r998182530
##########
src/Lucene.Net/Index/DocumentsWriterFlushControl.cs:
##########
@@ -563,17 +563,17 @@ public IEnumerator<ThreadState> AllActiveThreadStates()
private IEnumerator<ThreadState> GetPerThreadsIterator(int upto)
{
- return new IteratorAnonymousClass(this, upto);
+ return new EnumeratorAnonymousClass(this, upto);
}
- private class IteratorAnonymousClass : IEnumerator<ThreadState>
+ private class EnumeratorAnonymousClass : IEnumerator<ThreadState>
Review Comment:
Oops, this change should have been part of #698.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org