[GitHub] [incubator-druid] clintropolis commented on a change in pull request #9029: GenericIndexedWriter: Fix issue when writing large values to large columns.

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #9029: GenericIndexedWriter: Fix issue when writing large values to large columns.
URL: https://github.com/apache/incubator-druid/pull/9029#discussion_r357459129
 
 

 ##########
 File path: processing/src/test/java/org/apache/druid/segment/data/GenericIndexedWriterTest.java
 ##########
 @@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.segment.data;
+
+import org.apache.druid.common.config.NullHandling;
+import org.apache.druid.java.util.common.io.smoosh.FileSmoosher;
+import org.apache.druid.segment.writeout.OnHeapMemorySegmentWriteOutMedium;
+import org.junit.BeforeClass;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.nio.channels.FileChannel;
+import java.nio.file.StandardOpenOption;
+
+public class GenericIndexedWriterTest
+{
+  @Rule
+  public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+  @BeforeClass
+  public static void staticSetUp()
+  {
+    NullHandling.initializeForTests();
+  }
+
+  @Test
+  public void writeLargeValueIntoLargeColumn() throws IOException
+  {
+    // Regression test for https://github.com/apache/incubator-druid/issues/9027.
+
+    final GenericIndexedWriter<String> writer = new GenericIndexedWriter<>(
+        new OnHeapMemorySegmentWriteOutMedium(),
+        "test",
+        GenericIndexed.STRING_STRATEGY,
+        100
+    );
+
+    writer.setIntMaxForCasting(150);
+    writer.open();
+    writer.write("i really like writing strings");
+    writer.write("i really like writing strings");
+    writer.write("i really like writing strings i really like writing strings i really like writing strings");
+    writer.write("i really like writing strings");
 
 Review comment:
   I'm not convinced, maybe you should add a few more?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org