You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/30 20:22:17 UTC

[GitHub] [incubator-nuttx] acassis opened a new pull request #3253: pthread: Fix pthread_rwlock_init return error

acassis opened a new pull request #3253:
URL: https://github.com/apache/incubator-nuttx/pull/3253


   ## Summary
   According to OpenGroup pthread_rwlock_init() should return EINVAL
   if attr parameter is invalid.
   ## Impact
   Return the expected error code
   ## Testing
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] btashton commented on pull request #3253: pthread: Fix pthread_rwlock_init return error

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3253:
URL: https://github.com/apache/incubator-nuttx/pull/3253#issuecomment-811956552


   @acassis this is known. There is a somewhat rare corner case where if something is merged that changes files that have coding style issues after the point that you branches from it can show up on the PR check. You can either ignore it or rebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis commented on pull request #3253: pthread: Fix pthread_rwlock_init return error

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3253:
URL: https://github.com/apache/incubator-nuttx/pull/3253#issuecomment-811966654


   > @acassis this is known. There is a somewhat rare corner case where if something is merged that changes files that have coding style issues after the point that you branches from it can show up on the PR check. You can either ignore it or rebase.
   
   Thank you @btashton I just rebase it, let's see if now it will work!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis commented on pull request #3253: pthread: Fix pthread_rwlock_init return error

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3253:
URL: https://github.com/apache/incubator-nuttx/pull/3253#issuecomment-811899854


   Thank you @xiaoxiang781216 I noticed that my other PR is stopping because CI is detecting Coding Style issues in QEMU files that are not part of my PR...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] v01d commented on pull request #3253: pthread: Fix pthread_rwlock_init return error

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3253:
URL: https://github.com/apache/incubator-nuttx/pull/3253#issuecomment-811498692


   Fetch source was stuck since yesterday, I restarted it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3253: pthread: Fix pthread_rwlock_init return error

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3253:
URL: https://github.com/apache/incubator-nuttx/pull/3253


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] v01d commented on pull request #3253: pthread: Fix pthread_rwlock_init return error

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3253:
URL: https://github.com/apache/incubator-nuttx/pull/3253#issuecomment-811906874


   Let's monitor CI for some time. I hope that this isn't a problem introduced with the cancel workflow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] v01d commented on pull request #3253: pthread: Fix pthread_rwlock_init return error

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #3253:
URL: https://github.com/apache/incubator-nuttx/pull/3253#issuecomment-811503120


   For some reason this is queued but not being picked up. Can you rebase and force push?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3253: pthread: Fix pthread_rwlock_init return error

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3253:
URL: https://github.com/apache/incubator-nuttx/pull/3253#issuecomment-811741571


   CI stop the build without any error, let's merge this trival PR directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis commented on pull request #3253: pthread: Fix pthread_rwlock_init return error

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3253:
URL: https://github.com/apache/incubator-nuttx/pull/3253#issuecomment-810562841


   Thanks @gustavonihei :
   https://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_rwlock_init.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org