You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/12 11:27:22 UTC
[GitHub] [solr] thomaswoeckinger opened a new pull request, #1007: SOLR-16406: Take SOLR_MODULES into account
thomaswoeckinger opened a new pull request, #1007:
URL: https://github.com/apache/solr/pull/1007
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-16406: Take SOLR_MODULES into account
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
SOLR_MODULES (provided by solr.in.sh) is currently ignored.
# Solution
Take SOLR_MODULES into account by changing solr and solr.cmd scripts
# Tests
Added to /opt/solr/bin/solr and /opt/solr/bin/solr.in.sh locally and start the server
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thomaswoeckinger commented on pull request #1007: SOLR-16406: Take SOLR_MODULES into account
Posted by GitBox <gi...@apache.org>.
thomaswoeckinger commented on PR #1007:
URL: https://github.com/apache/solr/pull/1007#issuecomment-1250034042
@janhoy Added CHANGES.txt entry for 9.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1007: SOLR-16406: Take SOLR_MODULES into account
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #1007:
URL: https://github.com/apache/solr/pull/1007#issuecomment-1243629287
From a "does this fix the problem" view, the changes LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thomaswoeckinger commented on pull request #1007: SOLR-16406: Take SOLR_MODULES into account
Posted by GitBox <gi...@apache.org>.
thomaswoeckinger commented on PR #1007:
URL: https://github.com/apache/solr/pull/1007#issuecomment-1249916207
Sorry for the late response, i will add a entry tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1007: SOLR-16406: Take SOLR_MODULES into account
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1007:
URL: https://github.com/apache/solr/pull/1007#issuecomment-1249912815
Ping @thomaswoeckinger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1007: SOLR-16406: Take SOLR_MODULES into account
Posted by GitBox <gi...@apache.org>.
janhoy merged PR #1007:
URL: https://github.com/apache/solr/pull/1007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1007: SOLR-16406: Take SOLR_MODULES into account
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1007:
URL: https://github.com/apache/solr/pull/1007#issuecomment-1245028728
@thomaswoeckinger can you add a CHANGES.txt entry for 9.1, under bugfixes, then we can merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org