You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Neha Narkhede <ne...@gmail.com> on 2014/01/09 20:08:33 UTC
Review Request 16759: Patch for KAFKA-1199
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16759/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1199
https://issues.apache.org/jira/browse/KAFKA-1199
Repository: kafka
Description
-------
Included DEBUG and TRACE levels for access logging. At the DEBUG level, all parts of the request description that are proportional to the number of partitions or topics is omitted
Diffs
-----
core/src/main/scala/kafka/api/ControlledShutdownRequest.scala ad6a20d43f9bba937bc700d40c13945a01f007e8
core/src/main/scala/kafka/api/FetchRequest.scala d41a7056e2ad810974018a79ee696f1a6385b721
core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 3401afa05269b402c2d2166a2a3427d46234534e
core/src/main/scala/kafka/api/OffsetCommitRequest.scala 1cbe6e8de5a83d79b75249e661ccdacadacbb77c
core/src/main/scala/kafka/api/OffsetFetchRequest.scala a4c5623dbd48d9a0f21b87e39d63cde3604c64a0
core/src/main/scala/kafka/api/OffsetRequest.scala 0a94a6c352581774474d32f0539a3055e8fb1bb4
core/src/main/scala/kafka/api/ProducerRequest.scala c6063511173649dd8806c78e850f293419b3dc7a
core/src/main/scala/kafka/api/RequestOrResponse.scala ba59c31a93519eebd24b7a8ad80feea750851025
core/src/main/scala/kafka/api/StopReplicaRequest.scala efd704697024456b547f8344fcc535d37fc2ffb8
core/src/main/scala/kafka/api/TopicMetadataRequest.scala c5221c4e31a0e18ba435b7801ca0dbed01439677
core/src/main/scala/kafka/api/UpdateMetadataRequest.scala 2ead3644eb865be02c52a03ef7671d7466fc4a71
core/src/main/scala/kafka/network/RequestChannel.scala 330d3a0df280e2016de254619a0987b6ebee101c
Diff: https://reviews.apache.org/r/16759/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 16759: Patch for KAFKA-1199
Posted by Neha Narkhede <ne...@gmail.com>.
> On Jan. 10, 2014, 1 a.m., Guozhang Wang wrote:
> > core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala, line 196
> > <https://reviews.apache.org/r/16759/diff/1/?file=419769#file419769line196>
> >
> > I think the leaders info can also be put as detailed information, since it is simply a list of all leaders in the partition states, and they will likely be removed after 0.8.1
The API logs everything that is not proportional to topics or partitions. We still log information that is proportional to the # of brokers since typically there aren't many brokers in a Kafka cluster. We can remove the logging for leaders when the field really goes away.
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16759/#review31500
-----------------------------------------------------------
On Jan. 12, 2014, 10:58 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16759/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2014, 10:58 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1199
> https://issues.apache.org/jira/browse/KAFKA-1199
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Renamed describeRequest to describe and added describe for responses, but with the default toString. We can add the details when we find a use case for it
>
>
> Included DEBUG and TRACE levels for access logging. At the DEBUG level, all parts of the request description that are proportional to the number of partitions or topics is omitted
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/api/ControlledShutdownRequest.scala ad6a20d43f9bba937bc700d40c13945a01f007e8
> core/src/main/scala/kafka/api/ControlledShutdownResponse.scala b7c844892a9750b5824e2dd66fe928f75e8d039c
> core/src/main/scala/kafka/api/FetchRequest.scala d41a7056e2ad810974018a79ee696f1a6385b721
> core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 3401afa05269b402c2d2166a2a3427d46234534e
> core/src/main/scala/kafka/api/LeaderAndIsrResponse.scala 378b2b371377a1f5688da146e51a5c56358539f0
> core/src/main/scala/kafka/api/OffsetCommitRequest.scala 1cbe6e8de5a83d79b75249e661ccdacadacbb77c
> core/src/main/scala/kafka/api/OffsetCommitResponse.scala ad54bd63334b92e3ee3996da94586d39f560c057
> core/src/main/scala/kafka/api/OffsetFetchRequest.scala a4c5623dbd48d9a0f21b87e39d63cde3604c64a0
> core/src/main/scala/kafka/api/OffsetFetchResponse.scala ce03a13fc218bf67904a33bc3468d644ec7b5a14
> core/src/main/scala/kafka/api/OffsetRequest.scala 0a94a6c352581774474d32f0539a3055e8fb1bb4
> core/src/main/scala/kafka/api/OffsetResponse.scala fca76a209347737d81c45bf5dfd901edbd8e148b
> core/src/main/scala/kafka/api/ProducerRequest.scala c6063511173649dd8806c78e850f293419b3dc7a
> core/src/main/scala/kafka/api/ProducerResponse.scala d59c5bb8b8d735fcf8ffe0b4efad5bdf4f79af81
> core/src/main/scala/kafka/api/RequestOrResponse.scala ba59c31a93519eebd24b7a8ad80feea750851025
> core/src/main/scala/kafka/api/StopReplicaRequest.scala efd704697024456b547f8344fcc535d37fc2ffb8
> core/src/main/scala/kafka/api/StopReplicaResponse.scala c82eadd6a9f7c2054543a6877ede75c80d6ef036
> core/src/main/scala/kafka/api/TopicMetadataRequest.scala c5221c4e31a0e18ba435b7801ca0dbed01439677
> core/src/main/scala/kafka/api/TopicMetadataResponse.scala 290f263dfdceba9208fba9b6117fa7b66f04d88b
> core/src/main/scala/kafka/api/UpdateMetadataRequest.scala 2ead3644eb865be02c52a03ef7671d7466fc4a71
> core/src/main/scala/kafka/api/UpdateMetadataResponse.scala b1e42c39c8801fc93a8156d3ae7ad8d22d0f40e7
> core/src/main/scala/kafka/network/RequestChannel.scala 330d3a0df280e2016de254619a0987b6ebee101c
>
> Diff: https://reviews.apache.org/r/16759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 16759: Patch for KAFKA-1199
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16759/#review31500
-----------------------------------------------------------
Ship it!
core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala
<https://reviews.apache.org/r/16759/#comment60001>
I think the leaders info can also be put as detailed information, since it is simply a list of all leaders in the partition states, and they will likely be removed after 0.8.1
- Guozhang Wang
On Jan. 9, 2014, 7:08 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16759/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 7:08 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1199
> https://issues.apache.org/jira/browse/KAFKA-1199
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Included DEBUG and TRACE levels for access logging. At the DEBUG level, all parts of the request description that are proportional to the number of partitions or topics is omitted
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/api/ControlledShutdownRequest.scala ad6a20d43f9bba937bc700d40c13945a01f007e8
> core/src/main/scala/kafka/api/FetchRequest.scala d41a7056e2ad810974018a79ee696f1a6385b721
> core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 3401afa05269b402c2d2166a2a3427d46234534e
> core/src/main/scala/kafka/api/OffsetCommitRequest.scala 1cbe6e8de5a83d79b75249e661ccdacadacbb77c
> core/src/main/scala/kafka/api/OffsetFetchRequest.scala a4c5623dbd48d9a0f21b87e39d63cde3604c64a0
> core/src/main/scala/kafka/api/OffsetRequest.scala 0a94a6c352581774474d32f0539a3055e8fb1bb4
> core/src/main/scala/kafka/api/ProducerRequest.scala c6063511173649dd8806c78e850f293419b3dc7a
> core/src/main/scala/kafka/api/RequestOrResponse.scala ba59c31a93519eebd24b7a8ad80feea750851025
> core/src/main/scala/kafka/api/StopReplicaRequest.scala efd704697024456b547f8344fcc535d37fc2ffb8
> core/src/main/scala/kafka/api/TopicMetadataRequest.scala c5221c4e31a0e18ba435b7801ca0dbed01439677
> core/src/main/scala/kafka/api/UpdateMetadataRequest.scala 2ead3644eb865be02c52a03ef7671d7466fc4a71
> core/src/main/scala/kafka/network/RequestChannel.scala 330d3a0df280e2016de254619a0987b6ebee101c
>
> Diff: https://reviews.apache.org/r/16759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 16759: Patch for KAFKA-1199
Posted by Neha Narkhede <ne...@gmail.com>.
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16759/#review31555
-----------------------------------------------------------
On Jan. 12, 2014, 10:58 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16759/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2014, 10:58 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1199
> https://issues.apache.org/jira/browse/KAFKA-1199
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Renamed describeRequest to describe and added describe for responses, but with the default toString. We can add the details when we find a use case for it
>
>
> Included DEBUG and TRACE levels for access logging. At the DEBUG level, all parts of the request description that are proportional to the number of partitions or topics is omitted
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/api/ControlledShutdownRequest.scala ad6a20d43f9bba937bc700d40c13945a01f007e8
> core/src/main/scala/kafka/api/ControlledShutdownResponse.scala b7c844892a9750b5824e2dd66fe928f75e8d039c
> core/src/main/scala/kafka/api/FetchRequest.scala d41a7056e2ad810974018a79ee696f1a6385b721
> core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 3401afa05269b402c2d2166a2a3427d46234534e
> core/src/main/scala/kafka/api/LeaderAndIsrResponse.scala 378b2b371377a1f5688da146e51a5c56358539f0
> core/src/main/scala/kafka/api/OffsetCommitRequest.scala 1cbe6e8de5a83d79b75249e661ccdacadacbb77c
> core/src/main/scala/kafka/api/OffsetCommitResponse.scala ad54bd63334b92e3ee3996da94586d39f560c057
> core/src/main/scala/kafka/api/OffsetFetchRequest.scala a4c5623dbd48d9a0f21b87e39d63cde3604c64a0
> core/src/main/scala/kafka/api/OffsetFetchResponse.scala ce03a13fc218bf67904a33bc3468d644ec7b5a14
> core/src/main/scala/kafka/api/OffsetRequest.scala 0a94a6c352581774474d32f0539a3055e8fb1bb4
> core/src/main/scala/kafka/api/OffsetResponse.scala fca76a209347737d81c45bf5dfd901edbd8e148b
> core/src/main/scala/kafka/api/ProducerRequest.scala c6063511173649dd8806c78e850f293419b3dc7a
> core/src/main/scala/kafka/api/ProducerResponse.scala d59c5bb8b8d735fcf8ffe0b4efad5bdf4f79af81
> core/src/main/scala/kafka/api/RequestOrResponse.scala ba59c31a93519eebd24b7a8ad80feea750851025
> core/src/main/scala/kafka/api/StopReplicaRequest.scala efd704697024456b547f8344fcc535d37fc2ffb8
> core/src/main/scala/kafka/api/StopReplicaResponse.scala c82eadd6a9f7c2054543a6877ede75c80d6ef036
> core/src/main/scala/kafka/api/TopicMetadataRequest.scala c5221c4e31a0e18ba435b7801ca0dbed01439677
> core/src/main/scala/kafka/api/TopicMetadataResponse.scala 290f263dfdceba9208fba9b6117fa7b66f04d88b
> core/src/main/scala/kafka/api/UpdateMetadataRequest.scala 2ead3644eb865be02c52a03ef7671d7466fc4a71
> core/src/main/scala/kafka/api/UpdateMetadataResponse.scala b1e42c39c8801fc93a8156d3ae7ad8d22d0f40e7
> core/src/main/scala/kafka/network/RequestChannel.scala 330d3a0df280e2016de254619a0987b6ebee101c
>
> Diff: https://reviews.apache.org/r/16759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 16759: Patch for KAFKA-1199
Posted by Neha Narkhede <ne...@gmail.com>.
> On Jan. 10, 2014, 11:23 p.m., Jun Rao wrote:
> > core/src/main/scala/kafka/api/RequestOrResponse.scala, lines 41-45
> > <https://reviews.apache.org/r/16759/diff/1/?file=419774#file419774line41>
> >
> > It seems that this could be useful for the responses as well in the future to control the client side logging. Could we change that to just describe(details)? For responses, we can just default the implementation to toString() for now.
Included this change in the next patch.
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16759/#review31555
-----------------------------------------------------------
On Jan. 12, 2014, 10:58 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16759/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2014, 10:58 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1199
> https://issues.apache.org/jira/browse/KAFKA-1199
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Renamed describeRequest to describe and added describe for responses, but with the default toString. We can add the details when we find a use case for it
>
>
> Included DEBUG and TRACE levels for access logging. At the DEBUG level, all parts of the request description that are proportional to the number of partitions or topics is omitted
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/api/ControlledShutdownRequest.scala ad6a20d43f9bba937bc700d40c13945a01f007e8
> core/src/main/scala/kafka/api/ControlledShutdownResponse.scala b7c844892a9750b5824e2dd66fe928f75e8d039c
> core/src/main/scala/kafka/api/FetchRequest.scala d41a7056e2ad810974018a79ee696f1a6385b721
> core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 3401afa05269b402c2d2166a2a3427d46234534e
> core/src/main/scala/kafka/api/LeaderAndIsrResponse.scala 378b2b371377a1f5688da146e51a5c56358539f0
> core/src/main/scala/kafka/api/OffsetCommitRequest.scala 1cbe6e8de5a83d79b75249e661ccdacadacbb77c
> core/src/main/scala/kafka/api/OffsetCommitResponse.scala ad54bd63334b92e3ee3996da94586d39f560c057
> core/src/main/scala/kafka/api/OffsetFetchRequest.scala a4c5623dbd48d9a0f21b87e39d63cde3604c64a0
> core/src/main/scala/kafka/api/OffsetFetchResponse.scala ce03a13fc218bf67904a33bc3468d644ec7b5a14
> core/src/main/scala/kafka/api/OffsetRequest.scala 0a94a6c352581774474d32f0539a3055e8fb1bb4
> core/src/main/scala/kafka/api/OffsetResponse.scala fca76a209347737d81c45bf5dfd901edbd8e148b
> core/src/main/scala/kafka/api/ProducerRequest.scala c6063511173649dd8806c78e850f293419b3dc7a
> core/src/main/scala/kafka/api/ProducerResponse.scala d59c5bb8b8d735fcf8ffe0b4efad5bdf4f79af81
> core/src/main/scala/kafka/api/RequestOrResponse.scala ba59c31a93519eebd24b7a8ad80feea750851025
> core/src/main/scala/kafka/api/StopReplicaRequest.scala efd704697024456b547f8344fcc535d37fc2ffb8
> core/src/main/scala/kafka/api/StopReplicaResponse.scala c82eadd6a9f7c2054543a6877ede75c80d6ef036
> core/src/main/scala/kafka/api/TopicMetadataRequest.scala c5221c4e31a0e18ba435b7801ca0dbed01439677
> core/src/main/scala/kafka/api/TopicMetadataResponse.scala 290f263dfdceba9208fba9b6117fa7b66f04d88b
> core/src/main/scala/kafka/api/UpdateMetadataRequest.scala 2ead3644eb865be02c52a03ef7671d7466fc4a71
> core/src/main/scala/kafka/api/UpdateMetadataResponse.scala b1e42c39c8801fc93a8156d3ae7ad8d22d0f40e7
> core/src/main/scala/kafka/network/RequestChannel.scala 330d3a0df280e2016de254619a0987b6ebee101c
>
> Diff: https://reviews.apache.org/r/16759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 16759: Patch for KAFKA-1199
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16759/#review31555
-----------------------------------------------------------
For non-detailed description, would it be useful to include #partitions/topics?
core/src/main/scala/kafka/api/RequestOrResponse.scala
<https://reviews.apache.org/r/16759/#comment60082>
It seems that this could be useful for the responses as well in the future to control the client side logging. Could we change that to just describe(details)? For responses, we can just default the implementation to toString() for now.
- Jun Rao
On Jan. 9, 2014, 7:08 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16759/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 7:08 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1199
> https://issues.apache.org/jira/browse/KAFKA-1199
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Included DEBUG and TRACE levels for access logging. At the DEBUG level, all parts of the request description that are proportional to the number of partitions or topics is omitted
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/api/ControlledShutdownRequest.scala ad6a20d43f9bba937bc700d40c13945a01f007e8
> core/src/main/scala/kafka/api/FetchRequest.scala d41a7056e2ad810974018a79ee696f1a6385b721
> core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 3401afa05269b402c2d2166a2a3427d46234534e
> core/src/main/scala/kafka/api/OffsetCommitRequest.scala 1cbe6e8de5a83d79b75249e661ccdacadacbb77c
> core/src/main/scala/kafka/api/OffsetFetchRequest.scala a4c5623dbd48d9a0f21b87e39d63cde3604c64a0
> core/src/main/scala/kafka/api/OffsetRequest.scala 0a94a6c352581774474d32f0539a3055e8fb1bb4
> core/src/main/scala/kafka/api/ProducerRequest.scala c6063511173649dd8806c78e850f293419b3dc7a
> core/src/main/scala/kafka/api/RequestOrResponse.scala ba59c31a93519eebd24b7a8ad80feea750851025
> core/src/main/scala/kafka/api/StopReplicaRequest.scala efd704697024456b547f8344fcc535d37fc2ffb8
> core/src/main/scala/kafka/api/TopicMetadataRequest.scala c5221c4e31a0e18ba435b7801ca0dbed01439677
> core/src/main/scala/kafka/api/UpdateMetadataRequest.scala 2ead3644eb865be02c52a03ef7671d7466fc4a71
> core/src/main/scala/kafka/network/RequestChannel.scala 330d3a0df280e2016de254619a0987b6ebee101c
>
> Diff: https://reviews.apache.org/r/16759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 16759: Patch for KAFKA-1199
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16759/#review31635
-----------------------------------------------------------
Ship it!
Ship It!
- Jun Rao
On Jan. 12, 2014, 11:10 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16759/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2014, 11:10 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1199
> https://issues.apache.org/jira/browse/KAFKA-1199
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Removed the default implementation for describe() from RequestOrResponse
>
>
> Renamed describeRequest to describe and added describe for responses, but with the default toString. We can add the details when we find a use case for it
>
>
> Included DEBUG and TRACE levels for access logging. At the DEBUG level, all parts of the request description that are proportional to the number of partitions or topics is omitted
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/api/ControlledShutdownRequest.scala ad6a20d43f9bba937bc700d40c13945a01f007e8
> core/src/main/scala/kafka/api/ControlledShutdownResponse.scala b7c844892a9750b5824e2dd66fe928f75e8d039c
> core/src/main/scala/kafka/api/FetchRequest.scala d41a7056e2ad810974018a79ee696f1a6385b721
> core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 3401afa05269b402c2d2166a2a3427d46234534e
> core/src/main/scala/kafka/api/LeaderAndIsrResponse.scala 378b2b371377a1f5688da146e51a5c56358539f0
> core/src/main/scala/kafka/api/OffsetCommitRequest.scala 1cbe6e8de5a83d79b75249e661ccdacadacbb77c
> core/src/main/scala/kafka/api/OffsetCommitResponse.scala ad54bd63334b92e3ee3996da94586d39f560c057
> core/src/main/scala/kafka/api/OffsetFetchRequest.scala a4c5623dbd48d9a0f21b87e39d63cde3604c64a0
> core/src/main/scala/kafka/api/OffsetFetchResponse.scala ce03a13fc218bf67904a33bc3468d644ec7b5a14
> core/src/main/scala/kafka/api/OffsetRequest.scala 0a94a6c352581774474d32f0539a3055e8fb1bb4
> core/src/main/scala/kafka/api/OffsetResponse.scala fca76a209347737d81c45bf5dfd901edbd8e148b
> core/src/main/scala/kafka/api/ProducerRequest.scala c6063511173649dd8806c78e850f293419b3dc7a
> core/src/main/scala/kafka/api/ProducerResponse.scala d59c5bb8b8d735fcf8ffe0b4efad5bdf4f79af81
> core/src/main/scala/kafka/api/RequestOrResponse.scala ba59c31a93519eebd24b7a8ad80feea750851025
> core/src/main/scala/kafka/api/StopReplicaRequest.scala efd704697024456b547f8344fcc535d37fc2ffb8
> core/src/main/scala/kafka/api/StopReplicaResponse.scala c82eadd6a9f7c2054543a6877ede75c80d6ef036
> core/src/main/scala/kafka/api/TopicMetadataRequest.scala c5221c4e31a0e18ba435b7801ca0dbed01439677
> core/src/main/scala/kafka/api/TopicMetadataResponse.scala 290f263dfdceba9208fba9b6117fa7b66f04d88b
> core/src/main/scala/kafka/api/UpdateMetadataRequest.scala 2ead3644eb865be02c52a03ef7671d7466fc4a71
> core/src/main/scala/kafka/api/UpdateMetadataResponse.scala b1e42c39c8801fc93a8156d3ae7ad8d22d0f40e7
> core/src/main/scala/kafka/javaapi/TopicMetadataRequest.scala 05757a13ff149801ecbe3d886aaed48ae455993a
> core/src/main/scala/kafka/network/RequestChannel.scala 330d3a0df280e2016de254619a0987b6ebee101c
>
> Diff: https://reviews.apache.org/r/16759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 16759: Patch for KAFKA-1199
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16759/
-----------------------------------------------------------
(Updated Jan. 12, 2014, 11:10 p.m.)
Review request for kafka.
Bugs: KAFKA-1199
https://issues.apache.org/jira/browse/KAFKA-1199
Repository: kafka
Description (updated)
-------
Removed the default implementation for describe() from RequestOrResponse
Renamed describeRequest to describe and added describe for responses, but with the default toString. We can add the details when we find a use case for it
Included DEBUG and TRACE levels for access logging. At the DEBUG level, all parts of the request description that are proportional to the number of partitions or topics is omitted
Diffs (updated)
-----
core/src/main/scala/kafka/api/ControlledShutdownRequest.scala ad6a20d43f9bba937bc700d40c13945a01f007e8
core/src/main/scala/kafka/api/ControlledShutdownResponse.scala b7c844892a9750b5824e2dd66fe928f75e8d039c
core/src/main/scala/kafka/api/FetchRequest.scala d41a7056e2ad810974018a79ee696f1a6385b721
core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 3401afa05269b402c2d2166a2a3427d46234534e
core/src/main/scala/kafka/api/LeaderAndIsrResponse.scala 378b2b371377a1f5688da146e51a5c56358539f0
core/src/main/scala/kafka/api/OffsetCommitRequest.scala 1cbe6e8de5a83d79b75249e661ccdacadacbb77c
core/src/main/scala/kafka/api/OffsetCommitResponse.scala ad54bd63334b92e3ee3996da94586d39f560c057
core/src/main/scala/kafka/api/OffsetFetchRequest.scala a4c5623dbd48d9a0f21b87e39d63cde3604c64a0
core/src/main/scala/kafka/api/OffsetFetchResponse.scala ce03a13fc218bf67904a33bc3468d644ec7b5a14
core/src/main/scala/kafka/api/OffsetRequest.scala 0a94a6c352581774474d32f0539a3055e8fb1bb4
core/src/main/scala/kafka/api/OffsetResponse.scala fca76a209347737d81c45bf5dfd901edbd8e148b
core/src/main/scala/kafka/api/ProducerRequest.scala c6063511173649dd8806c78e850f293419b3dc7a
core/src/main/scala/kafka/api/ProducerResponse.scala d59c5bb8b8d735fcf8ffe0b4efad5bdf4f79af81
core/src/main/scala/kafka/api/RequestOrResponse.scala ba59c31a93519eebd24b7a8ad80feea750851025
core/src/main/scala/kafka/api/StopReplicaRequest.scala efd704697024456b547f8344fcc535d37fc2ffb8
core/src/main/scala/kafka/api/StopReplicaResponse.scala c82eadd6a9f7c2054543a6877ede75c80d6ef036
core/src/main/scala/kafka/api/TopicMetadataRequest.scala c5221c4e31a0e18ba435b7801ca0dbed01439677
core/src/main/scala/kafka/api/TopicMetadataResponse.scala 290f263dfdceba9208fba9b6117fa7b66f04d88b
core/src/main/scala/kafka/api/UpdateMetadataRequest.scala 2ead3644eb865be02c52a03ef7671d7466fc4a71
core/src/main/scala/kafka/api/UpdateMetadataResponse.scala b1e42c39c8801fc93a8156d3ae7ad8d22d0f40e7
core/src/main/scala/kafka/javaapi/TopicMetadataRequest.scala 05757a13ff149801ecbe3d886aaed48ae455993a
core/src/main/scala/kafka/network/RequestChannel.scala 330d3a0df280e2016de254619a0987b6ebee101c
Diff: https://reviews.apache.org/r/16759/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 16759: Patch for KAFKA-1199
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16759/
-----------------------------------------------------------
(Updated Jan. 12, 2014, 10:58 p.m.)
Review request for kafka.
Bugs: KAFKA-1199
https://issues.apache.org/jira/browse/KAFKA-1199
Repository: kafka
Description (updated)
-------
Renamed describeRequest to describe and added describe for responses, but with the default toString. We can add the details when we find a use case for it
Included DEBUG and TRACE levels for access logging. At the DEBUG level, all parts of the request description that are proportional to the number of partitions or topics is omitted
Diffs (updated)
-----
core/src/main/scala/kafka/api/ControlledShutdownRequest.scala ad6a20d43f9bba937bc700d40c13945a01f007e8
core/src/main/scala/kafka/api/ControlledShutdownResponse.scala b7c844892a9750b5824e2dd66fe928f75e8d039c
core/src/main/scala/kafka/api/FetchRequest.scala d41a7056e2ad810974018a79ee696f1a6385b721
core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 3401afa05269b402c2d2166a2a3427d46234534e
core/src/main/scala/kafka/api/LeaderAndIsrResponse.scala 378b2b371377a1f5688da146e51a5c56358539f0
core/src/main/scala/kafka/api/OffsetCommitRequest.scala 1cbe6e8de5a83d79b75249e661ccdacadacbb77c
core/src/main/scala/kafka/api/OffsetCommitResponse.scala ad54bd63334b92e3ee3996da94586d39f560c057
core/src/main/scala/kafka/api/OffsetFetchRequest.scala a4c5623dbd48d9a0f21b87e39d63cde3604c64a0
core/src/main/scala/kafka/api/OffsetFetchResponse.scala ce03a13fc218bf67904a33bc3468d644ec7b5a14
core/src/main/scala/kafka/api/OffsetRequest.scala 0a94a6c352581774474d32f0539a3055e8fb1bb4
core/src/main/scala/kafka/api/OffsetResponse.scala fca76a209347737d81c45bf5dfd901edbd8e148b
core/src/main/scala/kafka/api/ProducerRequest.scala c6063511173649dd8806c78e850f293419b3dc7a
core/src/main/scala/kafka/api/ProducerResponse.scala d59c5bb8b8d735fcf8ffe0b4efad5bdf4f79af81
core/src/main/scala/kafka/api/RequestOrResponse.scala ba59c31a93519eebd24b7a8ad80feea750851025
core/src/main/scala/kafka/api/StopReplicaRequest.scala efd704697024456b547f8344fcc535d37fc2ffb8
core/src/main/scala/kafka/api/StopReplicaResponse.scala c82eadd6a9f7c2054543a6877ede75c80d6ef036
core/src/main/scala/kafka/api/TopicMetadataRequest.scala c5221c4e31a0e18ba435b7801ca0dbed01439677
core/src/main/scala/kafka/api/TopicMetadataResponse.scala 290f263dfdceba9208fba9b6117fa7b66f04d88b
core/src/main/scala/kafka/api/UpdateMetadataRequest.scala 2ead3644eb865be02c52a03ef7671d7466fc4a71
core/src/main/scala/kafka/api/UpdateMetadataResponse.scala b1e42c39c8801fc93a8156d3ae7ad8d22d0f40e7
core/src/main/scala/kafka/network/RequestChannel.scala 330d3a0df280e2016de254619a0987b6ebee101c
Diff: https://reviews.apache.org/r/16759/diff/
Testing
-------
Thanks,
Neha Narkhede