You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/09/28 09:06:00 UTC
[jira] [Commented] (GEODE-5771) Geode should not allow user to
configure pdx persistence on a client
[ https://issues.apache.org/jira/browse/GEODE-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631578#comment-16631578 ]
ASF subversion and git services commented on GEODE-5771:
--------------------------------------------------------
Commit fbb132f227e81fa8aa79367d0394098eb967359d in geode's branch refs/heads/develop from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fbb132f ]
Merge pull request #2515 from jujoramos/feature/GEODE-5771
GEODE-5771: Deprecate PDX Persistence on Client
Currently, even when set, the PDX metadata is not persisted on the
client side (to avoid dealing with problems that might arise if the
client's PDX data is inconsistent with the server).
- Methods `setPdxPersistent` and `setPdxDiskStore` from
`ClientCacheFactory` have been deprecated.
- Attributes `persistent` and `disk-store-name` from the element `pdx`
have been deprecated (new complex type `client-pdx-type` has been
added to avoid messing with the pdx definition used for non-clients).
- A `warning` message will now be logged when creating the cache if we
detect that PDX persistence has been configured for a client cache.
- Added test methods to `ClientCacheFactoryJUnitTest`, also replaced
the usage of `junit.Assert` by `assertj`, and manual file
manipulation/cleanup by `TemporaryFolder` rule.
> Geode should not allow user to configure pdx persistence on a client
> --------------------------------------------------------------------
>
> Key: GEODE-5771
> URL: https://issues.apache.org/jira/browse/GEODE-5771
> Project: Geode
> Issue Type: Bug
> Reporter: Dan Smith
> Assignee: Juan José Ramos Cassella
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Geode currently does not support persistence of PDX data on the client side. This is to avoid dealing with issues that might arise if the client's PDX data is inconsistent with the server side.
> However, the client side API and XSD still allow the user to set pdx to be persistent. It appears that this setting is simply ignored:
> See ClientCacheFactory.setPdxPersistent and cache-1.0.xsd (the client-cache element embeds a pdx element which has a persistence flag.
> These methods should be deprecated or removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)