You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Nuno Marques (JIRA)" <de...@myfaces.apache.org> on 2006/09/22 15:47:23 UTC

[jira] Created: (TOMAHAWK-685) A sure NPE in CompareToValidator

A sure NPE in CompareToValidator
--------------------------------

                 Key: TOMAHAWK-685
                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-685
             Project: MyFaces Tomahawk
          Issue Type: Bug
          Components: Validators
    Affects Versions: 1.1.5-SNAPSHOT
            Reporter: Nuno Marques
            Priority: Trivial


332:    protected String getClassCastExceptionMessage(String name, Class clazz, Object object)
333:    {
334:        if (null == object)
335:            return name + " must be type " + clazz + " but is null" + object.getClass();
336:        else return name + " must be type " + clazz + " but is type " + object.getClass();
337:    }

if you look with attention to line 335 it's surelly a bad copy/paste from line 336 and object.getClass() will throw NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (TOMAHAWK-685) NPE during ClassCastException in CompareToValidator

Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-685?page=all ]

Mike Kienenberger resolved TOMAHAWK-685.
----------------------------------------

    Resolution: Fixed

Fixed.  Thanks for catching that!

> NPE during ClassCastException in CompareToValidator
> ---------------------------------------------------
>
>                 Key: TOMAHAWK-685
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-685
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Validators
>    Affects Versions: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT
>            Reporter: Nuno Marques
>            Priority: Minor
>             Fix For: 1.1.5-SNAPSHOT
>
>
> 332:    protected String getClassCastExceptionMessage(String name, Class clazz, Object object)
> 333:    {
> 334:        if (null == object)
> 335:            return name + " must be type " + clazz + " but is null" + object.getClass();
> 336:        else return name + " must be type " + clazz + " but is type " + object.getClass();
> 337:    }
> if you look with attention to line 335 it's surelly a bad copy/paste from line 336 and object.getClass() will throw NPE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira