You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "gianm (via GitHub)" <gi...@apache.org> on 2025/11/21 00:17:16 UTC
[PR] Don't kill tasks while a supervisor is stopping. (druid)
gianm opened a new pull request, #18767:
URL: https://github.com/apache/druid/pull/18767
Previously, if a supervisor was stopped while discovering tasks or updating their status, it could end up trying to kill those tasks because the callbacks on the requests to those tasks could fail as a result of the stopping. There should be no reason for an actively-stopping supervisor to kill a task, so this patch causes the shutdown functions to be no-ops while a supervisor is stopping.
This patch also ensures that when a supervisor transitions into the STOPPING state, that state takes priority over any other state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Don't kill tasks while a supervisor is stopping. (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm closed pull request #18767: Don't kill tasks while a supervisor is stopping.
URL: https://github.com/apache/druid/pull/18767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Don't kill tasks while a supervisor is stopping. (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm merged PR #18767:
URL: https://github.com/apache/druid/pull/18767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Don't kill tasks while a supervisor is stopping. (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #18767:
URL: https://github.com/apache/druid/pull/18767#issuecomment-3560744271
The specific scenario I saw this in had an error like:
```
Failed to return start time: Task java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@703f49ef[Not completed, task = java.util.concurrent.Executors$RunnableAdapter@7219380a[Wrapped task = org.apache.druid.indexing.seekablestream.supervisor.SeekableStreamSupervisor$$Lambda$1573/0x000000f801db8228@6ff15c29]] rejected from java.util.concurrent.ScheduledThreadPoolExecutor@1eb21b5c[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 1]
```
It happened because the callback on `getStartTimeAsync` tried to submit a task to a `scheduledExec` that had already been stopped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org