You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Armin Noll (JIRA)" <qp...@incubator.apache.org> on 2010/02/03 16:23:27 UTC
[jira] Created: (QPID-2386) Qpid C++ broker: add user ID in "SASL:
Authentication failed" log message
Qpid C++ broker: add user ID in "SASL: Authentication failed" log message
-------------------------------------------------------------------------
Key: QPID-2386
URL: https://issues.apache.org/jira/browse/QPID-2386
Project: Qpid
Issue Type: Bug
Components: C++ Broker
Environment: Red Hat Enterprise MRG 1.2
Reporter: Armin Noll
Priority: Minor
When the SASL authentication succeeds the broker then logs a message like the following:
2010-feb-03 15:28:45 info SASL: Authentication succeeded for: user@QPID
When the authentication fails it logs e.g.:
2010-feb-03 16:09:20 info SASL: Authentication failed: SASL(-13): authentication failure: Password verification failed
It would be helpful if the log message in the latter case would also contain the user ID and domain for which the authentication failed. It could look like
2010-feb-03 16:09:20 info SASL: Authentication failed for user@QPID: SASL(-13): authentication failure: Password verification failed
I think this can easily be achieved by applying the following change to the module SASLAUTHENTICATOR.CPP:
OLD:
} else {
QPID_LOG(info, "SASL: Authentication failed: " << sasl_errdetail(sasl_conn));
// TODO: Change to more specific exceptions, when they are
// available
switch (code) {
NEW:
} else {
QPID_LOG(info, "SASL: Authentication failed for " << const_cast<char*>(static_cast<const char*>(uid)) << ": " << sasl_errdetail(sasl_conn));
// TODO: Change to more specific exceptions, when they are
// available
switch (code) {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2386) Qpid C++ broker: add user ID in "SASL:
Authentication failed" log message
Posted by "Armin Noll (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Armin Noll updated QPID-2386:
-----------------------------
Issue Type: Improvement (was: Bug)
> Qpid C++ broker: add user ID in "SASL: Authentication failed" log message
> -------------------------------------------------------------------------
>
> Key: QPID-2386
> URL: https://issues.apache.org/jira/browse/QPID-2386
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Environment: Red Hat Enterprise MRG 1.2
> Reporter: Armin Noll
> Priority: Minor
>
> When the SASL authentication succeeds the broker then logs a message like the following:
> 2010-feb-03 15:28:45 info SASL: Authentication succeeded for: user@QPID
> When the authentication fails it logs e.g.:
> 2010-feb-03 16:09:20 info SASL: Authentication failed: SASL(-13): authentication failure: Password verification failed
> It would be helpful if the log message in the latter case would also contain the user ID and domain for which the authentication failed. It could look like
> 2010-feb-03 16:09:20 info SASL: Authentication failed for user@QPID: SASL(-13): authentication failure: Password verification failed
> I think this can easily be achieved by applying the following change to the module SASLAUTHENTICATOR.CPP:
> OLD:
> } else {
> QPID_LOG(info, "SASL: Authentication failed: " << sasl_errdetail(sasl_conn));
>
> // TODO: Change to more specific exceptions, when they are
> // available
> switch (code) {
> NEW:
> } else {
> QPID_LOG(info, "SASL: Authentication failed for " << const_cast<char*>(static_cast<const char*>(uid)) << ": " << sasl_errdetail(sasl_conn));
>
> // TODO: Change to more specific exceptions, when they are
> // available
> switch (code) {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Resolved: (QPID-2386) Qpid C++ broker: add user ID in "SASL:
Authentication failed" log message
Posted by "Gordon Sim (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim resolved QPID-2386.
------------------------------
Resolution: Fixed
> Qpid C++ broker: add user ID in "SASL: Authentication failed" log message
> -------------------------------------------------------------------------
>
> Key: QPID-2386
> URL: https://issues.apache.org/jira/browse/QPID-2386
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Environment: Red Hat Enterprise MRG 1.2
> Reporter: Armin Noll
> Assignee: Gordon Sim
> Priority: Minor
>
> When the SASL authentication succeeds the broker then logs a message like the following:
> 2010-feb-03 15:28:45 info SASL: Authentication succeeded for: user@QPID
> When the authentication fails it logs e.g.:
> 2010-feb-03 16:09:20 info SASL: Authentication failed: SASL(-13): authentication failure: Password verification failed
> It would be helpful if the log message in the latter case would also contain the user ID and domain for which the authentication failed. It could look like
> 2010-feb-03 16:09:20 info SASL: Authentication failed for user@QPID: SASL(-13): authentication failure: Password verification failed
> I think this can easily be achieved by applying the following change to the module SASLAUTHENTICATOR.CPP:
> OLD:
> } else {
> QPID_LOG(info, "SASL: Authentication failed: " << sasl_errdetail(sasl_conn));
>
> // TODO: Change to more specific exceptions, when they are
> // available
> switch (code) {
> NEW:
> } else {
> QPID_LOG(info, "SASL: Authentication failed for " << const_cast<char*>(static_cast<const char*>(uid)) << ": " << sasl_errdetail(sasl_conn));
>
> // TODO: Change to more specific exceptions, when they are
> // available
> switch (code) {
> This enhancement request has also been reported as Red Hat service request #1991714.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2386) Qpid C++ broker: add user ID in "SASL:
Authentication failed" log message
Posted by "Armin Noll (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Armin Noll updated QPID-2386:
-----------------------------
Description:
When the SASL authentication succeeds the broker then logs a message like the following:
2010-feb-03 15:28:45 info SASL: Authentication succeeded for: user@QPID
When the authentication fails it logs e.g.:
2010-feb-03 16:09:20 info SASL: Authentication failed: SASL(-13): authentication failure: Password verification failed
It would be helpful if the log message in the latter case would also contain the user ID and domain for which the authentication failed. It could look like
2010-feb-03 16:09:20 info SASL: Authentication failed for user@QPID: SASL(-13): authentication failure: Password verification failed
I think this can easily be achieved by applying the following change to the module SASLAUTHENTICATOR.CPP:
OLD:
} else {
QPID_LOG(info, "SASL: Authentication failed: " << sasl_errdetail(sasl_conn));
// TODO: Change to more specific exceptions, when they are
// available
switch (code) {
NEW:
} else {
QPID_LOG(info, "SASL: Authentication failed for " << const_cast<char*>(static_cast<const char*>(uid)) << ": " << sasl_errdetail(sasl_conn));
// TODO: Change to more specific exceptions, when they are
// available
switch (code) {
This enhancement request has also been reported as Red Hat service request #1991714.
was:
When the SASL authentication succeeds the broker then logs a message like the following:
2010-feb-03 15:28:45 info SASL: Authentication succeeded for: user@QPID
When the authentication fails it logs e.g.:
2010-feb-03 16:09:20 info SASL: Authentication failed: SASL(-13): authentication failure: Password verification failed
It would be helpful if the log message in the latter case would also contain the user ID and domain for which the authentication failed. It could look like
2010-feb-03 16:09:20 info SASL: Authentication failed for user@QPID: SASL(-13): authentication failure: Password verification failed
I think this can easily be achieved by applying the following change to the module SASLAUTHENTICATOR.CPP:
OLD:
} else {
QPID_LOG(info, "SASL: Authentication failed: " << sasl_errdetail(sasl_conn));
// TODO: Change to more specific exceptions, when they are
// available
switch (code) {
NEW:
} else {
QPID_LOG(info, "SASL: Authentication failed for " << const_cast<char*>(static_cast<const char*>(uid)) << ": " << sasl_errdetail(sasl_conn));
// TODO: Change to more specific exceptions, when they are
// available
switch (code) {
> Qpid C++ broker: add user ID in "SASL: Authentication failed" log message
> -------------------------------------------------------------------------
>
> Key: QPID-2386
> URL: https://issues.apache.org/jira/browse/QPID-2386
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Environment: Red Hat Enterprise MRG 1.2
> Reporter: Armin Noll
> Priority: Minor
>
> When the SASL authentication succeeds the broker then logs a message like the following:
> 2010-feb-03 15:28:45 info SASL: Authentication succeeded for: user@QPID
> When the authentication fails it logs e.g.:
> 2010-feb-03 16:09:20 info SASL: Authentication failed: SASL(-13): authentication failure: Password verification failed
> It would be helpful if the log message in the latter case would also contain the user ID and domain for which the authentication failed. It could look like
> 2010-feb-03 16:09:20 info SASL: Authentication failed for user@QPID: SASL(-13): authentication failure: Password verification failed
> I think this can easily be achieved by applying the following change to the module SASLAUTHENTICATOR.CPP:
> OLD:
> } else {
> QPID_LOG(info, "SASL: Authentication failed: " << sasl_errdetail(sasl_conn));
>
> // TODO: Change to more specific exceptions, when they are
> // available
> switch (code) {
> NEW:
> } else {
> QPID_LOG(info, "SASL: Authentication failed for " << const_cast<char*>(static_cast<const char*>(uid)) << ": " << sasl_errdetail(sasl_conn));
>
> // TODO: Change to more specific exceptions, when they are
> // available
> switch (code) {
> This enhancement request has also been reported as Red Hat service request #1991714.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-2386) Qpid C++ broker: add user ID in "SASL:
Authentication failed" log message
Posted by "Gordon Sim (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Sim reassigned QPID-2386:
--------------------------------
Assignee: Gordon Sim
> Qpid C++ broker: add user ID in "SASL: Authentication failed" log message
> -------------------------------------------------------------------------
>
> Key: QPID-2386
> URL: https://issues.apache.org/jira/browse/QPID-2386
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Environment: Red Hat Enterprise MRG 1.2
> Reporter: Armin Noll
> Assignee: Gordon Sim
> Priority: Minor
>
> When the SASL authentication succeeds the broker then logs a message like the following:
> 2010-feb-03 15:28:45 info SASL: Authentication succeeded for: user@QPID
> When the authentication fails it logs e.g.:
> 2010-feb-03 16:09:20 info SASL: Authentication failed: SASL(-13): authentication failure: Password verification failed
> It would be helpful if the log message in the latter case would also contain the user ID and domain for which the authentication failed. It could look like
> 2010-feb-03 16:09:20 info SASL: Authentication failed for user@QPID: SASL(-13): authentication failure: Password verification failed
> I think this can easily be achieved by applying the following change to the module SASLAUTHENTICATOR.CPP:
> OLD:
> } else {
> QPID_LOG(info, "SASL: Authentication failed: " << sasl_errdetail(sasl_conn));
>
> // TODO: Change to more specific exceptions, when they are
> // available
> switch (code) {
> NEW:
> } else {
> QPID_LOG(info, "SASL: Authentication failed for " << const_cast<char*>(static_cast<const char*>(uid)) << ": " << sasl_errdetail(sasl_conn));
>
> // TODO: Change to more specific exceptions, when they are
> // available
> switch (code) {
> This enhancement request has also been reported as Red Hat service request #1991714.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2386) Qpid C++ broker: add user ID in
"SASL: Authentication failed" log message
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829119#action_12829119 ]
Rajith Attapattu commented on QPID-2386:
----------------------------------------
Please attach the above code segment as a patch and please check the box " Grant license to ASF for inclusion in ASF works (as per the Apache License ยง5) "
> Qpid C++ broker: add user ID in "SASL: Authentication failed" log message
> -------------------------------------------------------------------------
>
> Key: QPID-2386
> URL: https://issues.apache.org/jira/browse/QPID-2386
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker
> Environment: Red Hat Enterprise MRG 1.2
> Reporter: Armin Noll
> Priority: Minor
>
> When the SASL authentication succeeds the broker then logs a message like the following:
> 2010-feb-03 15:28:45 info SASL: Authentication succeeded for: user@QPID
> When the authentication fails it logs e.g.:
> 2010-feb-03 16:09:20 info SASL: Authentication failed: SASL(-13): authentication failure: Password verification failed
> It would be helpful if the log message in the latter case would also contain the user ID and domain for which the authentication failed. It could look like
> 2010-feb-03 16:09:20 info SASL: Authentication failed for user@QPID: SASL(-13): authentication failure: Password verification failed
> I think this can easily be achieved by applying the following change to the module SASLAUTHENTICATOR.CPP:
> OLD:
> } else {
> QPID_LOG(info, "SASL: Authentication failed: " << sasl_errdetail(sasl_conn));
>
> // TODO: Change to more specific exceptions, when they are
> // available
> switch (code) {
> NEW:
> } else {
> QPID_LOG(info, "SASL: Authentication failed for " << const_cast<char*>(static_cast<const char*>(uid)) << ": " << sasl_errdetail(sasl_conn));
>
> // TODO: Change to more specific exceptions, when they are
> // available
> switch (code) {
> This enhancement request has also been reported as Red Hat service request #1991714.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org