[GitHub] GabrielBrascher commented on a change in pull request #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain

[gi...@git.apache.org]

GabrielBrascher commented on a change in pull request #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain
URL: https://github.com/apache/cloudstack/pull/2124#discussion_r118792114
 
 

 ##########
 File path: server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java
 ##########
 @@ -323,12 +330,12 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
         List<String> types = new ArrayList<String>();
 
         for (AffinityGroupProcessor processor : _affinityProcessors) {
-                if (processor.isAdminControlledGroup()) {
-                    continue; // we dont list the type if this group can be
-                              // created only as an admin/system operation.
-                }
-                types.add(processor.getType());
+            if (processor.isAdminControlledGroup()) {
 
 Review comment:
   At first I tried to submit without those changes in lines which I did not touch; However, it failed to pass in check style. When I let my environment make the code formatting, then all checks passed. I can review those changes and see if I can minimize them. But some will be necessary.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services