You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/16 07:20:20 UTC
[jira] [Commented] (CB-11693) THREAD WARNING: ['File'] took
'4534.373047' ms. Plugin should use a background thread.
[ https://issues.apache.org/jira/browse/CB-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422337#comment-15422337 ]
ASF GitHub Bot commented on CB-11693:
-------------------------------------
GitHub user matrosovN opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/190
CB-11693 ios: Make execution callback within doCopyMove method in the…
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
ios
### What does this PR do?
Callback within doCopyMove method was executed in main thread. PR lets to avoid 'THREAD WARNING' message, because it makes callback execution in the background thread.
### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
… background thread
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosovN/cordova-plugin-file CB-11693
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #190
----
commit 66100807aca21b08ffef22ec8d1b85fb5195349a
Author: Nikita Matrosov <ni...@rp.ru>
Date: 2016-08-16T07:07:39Z
CB-11693 ios: Make execution callback within doCopyMove method in the background thread
----
> THREAD WARNING: ['File'] took '4534.373047' ms. Plugin should use a background thread.
> --------------------------------------------------------------------------------------
>
> Key: CB-11693
> URL: https://issues.apache.org/jira/browse/CB-11693
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
> Affects Versions: 4.2.0
> Reporter: Richard Hua
> Labels: easyfix, performance
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Full details and a fix is here: https://github.com/Microsoft/cordova-plugin-code-push/issues/156
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org