You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (Created) (JIRA)" <ji...@apache.org> on 2011/12/21 17:51:30 UTC

[jira] [Created] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

TestConcurrentTopicAcquisition sometimes hangs
----------------------------------------------

                 Key: BOOKKEEPER-146
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
             Project: Bookkeeper
          Issue Type: Bug
            Reporter: Ivan Kelly
             Fix For: 4.1.0


to repro
{code}
while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
{code}

The stacktrace where it hangs looks very like BOOKKEEPER-5

{code}
"main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
   java.lang.Thread.State: TIMED_WAITING (parking)
	at sun.misc.Unsafe.park(Native Method)
	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
	at junit.framework.TestCase.runBare(TestCase.java:140)
	at junit.framework.TestResult$1.protect(TestResult.java:110)
	at junit.framework.TestResult.runProtected(TestResult.java:128)
	at junit.framework.TestResult.run(TestResult.java:113)
	at junit.framework.TestCase.run(TestCase.java:124)
	at junit.framework.TestSuite.runTest(TestSuite.java:232)
	at junit.framework.TestSuite.run(TestSuite.java:227)
	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)

{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "Flavio Junqueira (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavio Junqueira updated BOOKKEEPER-146:
----------------------------------------

    Priority: Blocker  (was: Major)
    
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Priority: Blocker
>             Fix For: 4.1.0
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-146:
----------------------------------

    Attachment: BOOKKEEPER-146.diff

It's been running in a loop for 30 minutes now, and doesn't seem to be hanging. Main problem was that even after the hedwig client was closed, a subscription request could succeed and add a channel to the channel list, though hedwig client had already moved by the point at which it closed them.
                
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Sijie Guo
>            Priority: Blocker
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-146.diff
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276825#comment-13276825 ] 

jiraposter@reviews.apache.org commented on BOOKKEEPER-146:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5144/
-----------------------------------------------------------

Review request for bookkeeper.


Summary
-------

It's been running in a loop for 30 minutes now, and doesn't seem to be hanging. Main problem was that even after the hedwig client was closed, a subscription request could succeed and add a channel to the channel list, though hedwig client had already moved by the point at which it closed them.


This addresses bug BOOKKEEPER-146.
    https://issues.apache.org/jira/browse/BOOKKEEPER-146


Diffs
-----

  hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java 0c8634c 
  hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java a8552f4 
  hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java 603766c 
  hedwig-client/src/main/java/org/apache/hedwig/client/netty/ConnectCallback.java f5077b0 
  hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClientImpl.java 806cdef 

Diff: https://reviews.apache.org/r/5144/diff


Testing
-------


Thanks,

Ivan


                
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Blocker
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-146.diff
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "Flavio Junqueira (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavio Junqueira reassigned BOOKKEEPER-146:
-------------------------------------------

    Assignee: Ivan Kelly
    
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Blocker
>             Fix For: 4.1.0
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271257#comment-13271257 ] 

Sijie Guo commented on BOOKKEEPER-146:
--------------------------------------

@Flavio, what Ivan mentioned is right, seems that it is caused by some un-referenced channels. I was trying to find and close them.
                
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Sijie Guo
>            Priority: Blocker
>             Fix For: 4.1.0
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228336#comment-13228336 ] 

Flavio Junqueira commented on BOOKKEEPER-146:
---------------------------------------------

Keeping this one for 4.1.0.
                
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>             Fix For: 4.1.0
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278017#comment-13278017 ] 

jiraposter@reviews.apache.org commented on BOOKKEEPER-146:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5144/
-----------------------------------------------------------

(Updated 2012-05-17 17:49:36.598125)


Review request for bookkeeper.


Summary
-------

It's been running in a loop for 30 minutes now, and doesn't seem to be hanging. Main problem was that even after the hedwig client was closed, a subscription request could succeed and add a channel to the channel list, though hedwig client had already moved by the point at which it closed them.


This addresses bug BOOKKEEPER-146.
    https://issues.apache.org/jira/browse/BOOKKEEPER-146


Diffs (updated)
-----

  hedwig-client/src/main/java/org/apache/hedwig/client/netty/ConnectCallback.java f5077b0 
  hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClientImpl.java 806cdef 
  hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java 603766c 
  hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java 0c8634c 
  hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java a8552f4 

Diff: https://reviews.apache.org/r/5144/diff


Testing
-------


Thanks,

Ivan


                
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Blocker
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-146.diff, BOOKKEEPER-146.diff
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-146:
----------------------------------

    Attachment: BOOKKEEPER-146.diff

Addressed Sijie's comments in new patch.
                
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Blocker
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-146.diff, BOOKKEEPER-146.diff
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277567#comment-13277567 ] 

jiraposter@reviews.apache.org commented on BOOKKEEPER-146:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5144/#review7950
-----------------------------------------------------------


thanks Ivan. the patch seems great. just some slight comments.


hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java
<https://reviews.apache.org/r/5144/#comment17288>

    it would be better to move line 'closed = true;' to the top of close(). because you used closed to avoid new channel being storeHost2ChannelMapping.



hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java
<https://reviews.apache.org/r/5144/#comment17289>

    do we need to put the closing logic in closeLock synchronization block?
    
    if we had acquired closeLock and set closed to true, no channel could be put into topicSubscriber2Channel again.


- Sijie


On 2012-05-16 15:48:50, Ivan Kelly wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/5144/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-05-16 15:48:50)
bq.  
bq.  
bq.  Review request for bookkeeper.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  It's been running in a loop for 30 minutes now, and doesn't seem to be hanging. Main problem was that even after the hedwig client was closed, a subscription request could succeed and add a channel to the channel list, though hedwig client had already moved by the point at which it closed them.
bq.  
bq.  
bq.  This addresses bug BOOKKEEPER-146.
bq.      https://issues.apache.org/jira/browse/BOOKKEEPER-146
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java 0c8634c 
bq.    hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java a8552f4 
bq.    hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java 603766c 
bq.    hedwig-client/src/main/java/org/apache/hedwig/client/netty/ConnectCallback.java f5077b0 
bq.    hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClientImpl.java 806cdef 
bq.  
bq.  Diff: https://reviews.apache.org/r/5144/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ivan
bq.  
bq.


                
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Blocker
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-146.diff
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282151#comment-13282151 ] 

Sijie Guo commented on BOOKKEEPER-146:
--------------------------------------

@Ivan, the patch looks good to me. +1
                
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Blocker
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-146.diff, BOOKKEEPER-146.diff
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271227#comment-13271227 ] 

Flavio Junqueira commented on BOOKKEEPER-146:
---------------------------------------------

Is the issue here caused by the problem we had in BOOKKEEPER-5?
                
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Sijie Guo
>            Priority: Blocker
>             Fix For: 4.1.0
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavio Junqueira reassigned BOOKKEEPER-146:
-------------------------------------------

    Assignee: Sijie Guo  (was: Ivan Kelly)

Reassigning to Sijie.
                
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Sijie Guo
>            Priority: Blocker
>             Fix For: 4.1.0
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283339#comment-13283339 ] 

Hudson commented on BOOKKEEPER-146:
-----------------------------------

Integrated in bookkeeper-trunk #525 (See [https://builds.apache.org/job/bookkeeper-trunk/525/])
    BOOKKEEPER-146: TestConcurrentTopicAcquisition sometimes hangs (ivank) (Revision 1342550)

     Result = SUCCESS
ivank : 
Files : 
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/ConnectCallback.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClientImpl.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java

                
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>            Priority: Blocker
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-146.diff, BOOKKEEPER-146.diff
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-146) TestConcurrentTopicAcquisition sometimes hangs

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271240#comment-13271240 ] 

Ivan Kelly commented on BOOKKEEPER-146:
---------------------------------------

Similar, but not the same thing. Netty Channels are being created, but sometimes left dangling. It's mostly not a race as in BOOKKEEPER-5. There are some callbacks which get the channel and then create a new one without closing the old one.
                
> TestConcurrentTopicAcquisition sometimes hangs
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-146
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-146
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Sijie Guo
>            Priority: Blocker
>             Fix For: 4.1.0
>
>
> to repro
> {code}
> while [ $? = 0 ]; do mvn test -Dtest=TestConcurrentTopicAcquisition; done
> {code}
> The stacktrace where it hangs looks very like BOOKKEEPER-5
> {code}
> "main" prio=5 tid=102801000 nid=0x100601000 waiting on condition [1005ff000]
>    java.lang.Thread.State: TIMED_WAITING (parking)
> 	at sun.misc.Unsafe.park(Native Method)
> 	- parking to wait for  <7bd8e1090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
> 	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2025)
> 	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1253)
> 	at org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:107)
> 	at org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.releaseExternalResources(NioClientSocketChannelFactory.java:143)
> 	at org.apache.hedwig.client.netty.HedwigClientImpl.close(HedwigClientImpl.java:234)
> 	at org.apache.hedwig.client.HedwigClient.close(HedwigClient.java:70)
> 	at org.apache.hedwig.server.topics.TestConcurrentTopicAcquisition.tearDown(TestConcurrentTopicAcquisition.java:99)
> 	at junit.framework.TestCase.runBare(TestCase.java:140)
> 	at junit.framework.TestResult$1.protect(TestResult.java:110)
> 	at junit.framework.TestResult.runProtected(TestResult.java:128)
> 	at junit.framework.TestResult.run(TestResult.java:113)
> 	at junit.framework.TestCase.run(TestCase.java:124)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:232)
> 	at junit.framework.TestSuite.run(TestSuite.java:227)
> 	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira