You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/01/05 21:27:28 UTC
[GitHub] [trafficserver] rob05c opened a new pull request #8580: Ports #7897 from core strategies to parent_select plugin.
rob05c opened a new pull request #8580:
URL: https://github.com/apache/trafficserver/pull/8580
Ports #7897 from core strategies to parent_select plugin.
Adds a new peering_ring mode to strategies, which allows parenting to
a consistent-hashed peer instead of the next hierarchical tier,
which can be useful in many situations, especially when the requesting
client itself is requesting different caches for the same key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #8580: Ports #7897 from core strategies to parent_select plugin.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #8580:
URL: https://github.com/apache/trafficserver/pull/8580#issuecomment-1006143285
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #8580: Ports #7897 from core strategies to parent_select plugin.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #8580:
URL: https://github.com/apache/trafficserver/pull/8580#issuecomment-1006142241
[approve ci AuTest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras removed a comment on pull request #8580: Ports #7897 from core strategies to parent_select plugin.
Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #8580:
URL: https://github.com/apache/trafficserver/pull/8580#issuecomment-1006141728
[approve ci AuTest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #8580: Ports #7897 from core strategies to parent_select plugin.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #8580:
URL: https://github.com/apache/trafficserver/pull/8580#issuecomment-1006141728
[approve ci AuTest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] rob05c merged pull request #8580: Ports #7897 from core strategies to parent_select plugin.
Posted by GitBox <gi...@apache.org>.
rob05c merged pull request #8580:
URL: https://github.com/apache/trafficserver/pull/8580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #8580: Ports #7897 from core strategies to parent_select plugin.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #8580:
URL: https://github.com/apache/trafficserver/pull/8580#issuecomment-1006142241
[approve ci AuTest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8580: Ports #7897 from core strategies to parent_select plugin.
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8580:
URL: https://github.com/apache/trafficserver/pull/8580#issuecomment-1042434439
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #8580: Ports #7897 from core strategies to parent_select plugin.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #8580:
URL: https://github.com/apache/trafficserver/pull/8580#issuecomment-1006143285
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on a change in pull request #8580: Ports #7897 from core strategies to parent_select plugin.
Posted by GitBox <gi...@apache.org>.
ywkaras commented on a change in pull request #8580:
URL: https://github.com/apache/trafficserver/pull/8580#discussion_r782530296
##########
File path: plugins/experimental/parent_select/consistenthash.cc
##########
@@ -248,11 +256,13 @@ PLNextHopConsistentHash::getHashKey(uint64_t sm_id, TSMBuffer reqp, TSMLoc url,
}
static void
-makeNextParentErr(const char **hostname, size_t *hostname_len, in_port_t *port)
+makeNextParentErr(const char **hostname, size_t *hostname_len, in_port_t *port, bool *retry, bool *no_cache)
{
*hostname = nullptr;
*hostname_len = 0;
*port = 0;
+ *retry = false;
+ *no_cache = false;
Review comment:
This is how people who didn't go to graduate school would do this: https://godbolt.org/z/M3z5fY46n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org