[GitHub] [spark] rxin commented on a change in pull request #24233: [SPARK-26356][SQL] remove SaveMode from data source v2

[GitBox <gi...@apache.org>]

rxin commented on a change in pull request #24233: [SPARK-26356][SQL] remove SaveMode from data source v2
URL: https://github.com/apache/spark/pull/24233#discussion_r272763456
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/noop/NoopSuite.scala
 ##########
 @@ -54,7 +56,7 @@ class NoopSuite extends SharedSQLContext {
           accum.add(1)
           x
         }
-        .write.format("noop").save()
+        .write.format("noop").mode("append").save()
 
 Review comment:
   We can't change the default like this. It'd be a huge nightmare for users to upgrade, because it's a subtle semantic change. If we want to piss off all Spark users that write data pipelines, changing the default from one to another here is a great way to achieve that.
   
   We can however introduce new APIs to make it more obvious what's happening.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org