You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2007/09/03 17:34:58 UTC
[jira] Created: (JCR-1108) JCR2SPI: error level logging when
cleaning up session locks
JCR2SPI: error level logging when cleaning up session locks
------------------------------------------------------------
Key: JCR-1108
URL: https://issues.apache.org/jira/browse/JCR-1108
Project: Jackrabbit
Issue Type: Improvement
Components: SPI
Reporter: Julian Reschke
Priority: Minor
LockManagerImpl.loggingOut() tries to unlock nodes that have a session lock. If, while doing so, a RepositoryException is thrown, this gets locked on error level.
The TCK tests tearDown code removes test nodes using a separate session; thus we see RepositoryExceptions for the simple reason that the nodes have already been removed by somebody else.
Proposal: handle ItemNotFoundExc and PathNotFoundExc separately, not logging them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1108) JCR2SPI: error level logging when
cleaning up session locks
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved JCR-1108.
-------------------------
Resolution: Fixed
Fix Version/s: 1.4
> JCR2SPI: error level logging when cleaning up session locks
> ------------------------------------------------------------
>
> Key: JCR-1108
> URL: https://issues.apache.org/jira/browse/JCR-1108
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Julian Reschke
> Assignee: angela
> Priority: Minor
> Fix For: 1.4
>
>
> LockManagerImpl.loggingOut() tries to unlock nodes that have a session lock. If, while doing so, a RepositoryException is thrown, this gets locked on error level.
> The TCK tests tearDown code removes test nodes using a separate session; thus we see RepositoryExceptions for the simple reason that the nodes have already been removed by somebody else.
> Proposal: handle ItemNotFoundExc and PathNotFoundExc separately, not logging them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1108) JCR2SPI: error level logging when
cleaning up session locks
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524550 ]
Julian Reschke commented on JCR-1108:
-------------------------------------
Turns out that the TCK indeed uses the same session (otherwise it would fail :-).
Which leaves us with the question why LockManagerImpl doesn't realize that the nodes are already gone...
> JCR2SPI: error level logging when cleaning up session locks
> ------------------------------------------------------------
>
> Key: JCR-1108
> URL: https://issues.apache.org/jira/browse/JCR-1108
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Julian Reschke
> Priority: Minor
>
> LockManagerImpl.loggingOut() tries to unlock nodes that have a session lock. If, while doing so, a RepositoryException is thrown, this gets locked on error level.
> The TCK tests tearDown code removes test nodes using a separate session; thus we see RepositoryExceptions for the simple reason that the nodes have already been removed by somebody else.
> Proposal: handle ItemNotFoundExc and PathNotFoundExc separately, not logging them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1108) JCR2SPI: error level logging when
cleaning up session locks
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537278 ]
angela commented on JCR-1108:
-----------------------------
> [...] why LockManagerImpl doesn't realize that the nodes are already gone...
because the lock-state objects currently only listen to jcr:lockIsDeep property being removed and only
in case of cache-behaviour observation.
probably the lock-state objects should also be aware of a removal of the lock-holding-state (for all types of cache-behaviour)
> JCR2SPI: error level logging when cleaning up session locks
> ------------------------------------------------------------
>
> Key: JCR-1108
> URL: https://issues.apache.org/jira/browse/JCR-1108
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Julian Reschke
> Priority: Minor
>
> LockManagerImpl.loggingOut() tries to unlock nodes that have a session lock. If, while doing so, a RepositoryException is thrown, this gets locked on error level.
> The TCK tests tearDown code removes test nodes using a separate session; thus we see RepositoryExceptions for the simple reason that the nodes have already been removed by somebody else.
> Proposal: handle ItemNotFoundExc and PathNotFoundExc separately, not logging them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1108) JCR2SPI: error level logging when
cleaning up session locks
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela reassigned JCR-1108:
---------------------------
Assignee: angela
> JCR2SPI: error level logging when cleaning up session locks
> ------------------------------------------------------------
>
> Key: JCR-1108
> URL: https://issues.apache.org/jira/browse/JCR-1108
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Julian Reschke
> Assignee: angela
> Priority: Minor
>
> LockManagerImpl.loggingOut() tries to unlock nodes that have a session lock. If, while doing so, a RepositoryException is thrown, this gets locked on error level.
> The TCK tests tearDown code removes test nodes using a separate session; thus we see RepositoryExceptions for the simple reason that the nodes have already been removed by somebody else.
> Proposal: handle ItemNotFoundExc and PathNotFoundExc separately, not logging them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.