You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mohit Ambalkar via Review Board <no...@reviews.apache.org> on 2023/05/11 12:32:38 UTC
Review Request 74431: Add flag based support for mounting db volume in dev-support scripts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74431/
-----------------------------------------------------------
Review request for ranger and Jai Patel.
Repository: ranger
Description
-------
Currently, the DB which gets used via dev-support scripts is not mounted to any local storage. As a result, we lose all data if docker containers are shutdown and brought up again.
Raising this ticket to have a flag based support for mounting the db volumes.
Diffs
-----
dev-support/ranger-docker/.env 3f795abde
dev-support/ranger-docker/docker-compose.ranger-postgres-mounted.yml PRE-CREATION
ranger_in_docker 2057bde3e
Diff: https://reviews.apache.org/r/74431/diff/1/
Testing
-------
tested and verified in UI. mounted db changes are visible
Thanks,
Mohit Ambalkar
Re: Review Request 74431: Add flag based support for mounting db volume in dev-support scripts
Posted by Mohit Ambalkar via Review Board <no...@reviews.apache.org>.
> On May 15, 2023, 7:19 a.m., Abhishek Kumar wrote:
> > dev-support/ranger-docker/docker-compose.ranger-postgres-mounted.yml
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/74431/diff/3/?file=2276349#file2276349line1>
> >
> > A new compose file just to mount a volume may not be required, please consider command line options to mount a volume using -v or --mount.
docker-compose doesn't support -v nor does it support jinja templating bydefault.. hence implemented this using separate files
- Mohit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74431/#review225456
-----------------------------------------------------------
On May 15, 2023, 6:26 a.m., Mohit Ambalkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74431/
> -----------------------------------------------------------
>
> (Updated May 15, 2023, 6:26 a.m.)
>
>
> Review request for ranger and Jai Patel.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, the DB which gets used via dev-support scripts is not mounted to any local storage. As a result, we lose all data if docker containers are shutdown and brought up again.
> Raising this ticket to have a flag based support for mounting the db volumes.
>
>
> Diffs
> -----
>
> dev-support/ranger-docker/.env 3f795abde
> dev-support/ranger-docker/docker-compose.ranger-postgres-mounted.yml PRE-CREATION
> dev-support/ranger-docker/postgres-db /readme.pages PRE-CREATION
> ranger_in_docker 2057bde3e
>
>
> Diff: https://reviews.apache.org/r/74431/diff/3/
>
>
> Testing
> -------
>
> tested and verified in UI. mounted db changes are visible
>
>
> Thanks,
>
> Mohit Ambalkar
>
>
Re: Review Request 74431: Add flag based support for mounting db volume in dev-support scripts
Posted by Abhishek Kumar <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74431/#review225456
-----------------------------------------------------------
dev-support/ranger-docker/docker-compose.ranger-postgres-mounted.yml
Lines 1 (patched)
<https://reviews.apache.org/r/74431/#comment314053>
A new compose file just to mount a volume may not be required, please consider command line options to mount a volume using -v or --mount.
- Abhishek Kumar
On May 15, 2023, 6:26 a.m., Mohit Ambalkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74431/
> -----------------------------------------------------------
>
> (Updated May 15, 2023, 6:26 a.m.)
>
>
> Review request for ranger and Jai Patel.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, the DB which gets used via dev-support scripts is not mounted to any local storage. As a result, we lose all data if docker containers are shutdown and brought up again.
> Raising this ticket to have a flag based support for mounting the db volumes.
>
>
> Diffs
> -----
>
> dev-support/ranger-docker/.env 3f795abde
> dev-support/ranger-docker/docker-compose.ranger-postgres-mounted.yml PRE-CREATION
> dev-support/ranger-docker/postgres-db /readme.pages PRE-CREATION
> ranger_in_docker 2057bde3e
>
>
> Diff: https://reviews.apache.org/r/74431/diff/3/
>
>
> Testing
> -------
>
> tested and verified in UI. mounted db changes are visible
>
>
> Thanks,
>
> Mohit Ambalkar
>
>
Re: Review Request 74431: Add flag based support for mounting db volume in dev-support scripts
Posted by Mohit Ambalkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74431/
-----------------------------------------------------------
(Updated May 17, 2023, 9:44 a.m.)
Review request for ranger and Jai Patel.
Repository: ranger
Description
-------
Currently, the DB which gets used via dev-support scripts is not mounted to any local storage. As a result, we lose all data if docker containers are shutdown and brought up again.
Raising this ticket to have a flag based support for mounting the db volumes.
Diffs (updated)
-----
dev-support/ranger-docker/.env 3f795abde
dev-support/ranger-docker/docker-compose.ranger-postgres-mounted.yml PRE-CREATION
ranger_in_docker 2057bde3e
Diff: https://reviews.apache.org/r/74431/diff/5/
Changes: https://reviews.apache.org/r/74431/diff/4-5/
Testing
-------
tested and verified in UI. mounted db changes are visible
Thanks,
Mohit Ambalkar
Re: Review Request 74431: Add flag based support for mounting db volume in dev-support scripts
Posted by Jai Patel via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74431/#review225458
-----------------------------------------------------------
dev-support/ranger-docker/docker-compose.ranger-postgres.yml
Line 20 (original), 19 (patched)
<https://reviews.apache.org/r/74431/#comment314055>
If there are no changes in this file, don't add in the patch.
- Jai Patel
On May 16, 2023, 11:53 a.m., Mohit Ambalkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74431/
> -----------------------------------------------------------
>
> (Updated May 16, 2023, 11:53 a.m.)
>
>
> Review request for ranger and Jai Patel.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, the DB which gets used via dev-support scripts is not mounted to any local storage. As a result, we lose all data if docker containers are shutdown and brought up again.
> Raising this ticket to have a flag based support for mounting the db volumes.
>
>
> Diffs
> -----
>
> dev-support/ranger-docker/.env 3f795abde
> dev-support/ranger-docker/docker-compose.ranger-postgres-mounted.yml PRE-CREATION
> dev-support/ranger-docker/docker-compose.ranger-postgres.yml f89168409
> embeddedwebserver/scripts/ranger-admin-services.sh a76f0986c
> ranger_in_docker 2057bde3e
>
>
> Diff: https://reviews.apache.org/r/74431/diff/4/
>
>
> Testing
> -------
>
> tested and verified in UI. mounted db changes are visible
>
>
> Thanks,
>
> Mohit Ambalkar
>
>
Re: Review Request 74431: Add flag based support for mounting db volume in dev-support scripts
Posted by Mohit Ambalkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74431/
-----------------------------------------------------------
(Updated May 16, 2023, 11:53 a.m.)
Review request for ranger and Jai Patel.
Repository: ranger
Description
-------
Currently, the DB which gets used via dev-support scripts is not mounted to any local storage. As a result, we lose all data if docker containers are shutdown and brought up again.
Raising this ticket to have a flag based support for mounting the db volumes.
Diffs (updated)
-----
dev-support/ranger-docker/.env 3f795abde
dev-support/ranger-docker/docker-compose.ranger-postgres-mounted.yml PRE-CREATION
dev-support/ranger-docker/docker-compose.ranger-postgres.yml f89168409
embeddedwebserver/scripts/ranger-admin-services.sh a76f0986c
ranger_in_docker 2057bde3e
Diff: https://reviews.apache.org/r/74431/diff/4/
Changes: https://reviews.apache.org/r/74431/diff/3-4/
Testing
-------
tested and verified in UI. mounted db changes are visible
Thanks,
Mohit Ambalkar
Re: Review Request 74431: Add flag based support for mounting db volume in dev-support scripts
Posted by Mohit Ambalkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74431/
-----------------------------------------------------------
(Updated May 15, 2023, 6:26 a.m.)
Review request for ranger and Jai Patel.
Repository: ranger
Description
-------
Currently, the DB which gets used via dev-support scripts is not mounted to any local storage. As a result, we lose all data if docker containers are shutdown and brought up again.
Raising this ticket to have a flag based support for mounting the db volumes.
Diffs (updated)
-----
dev-support/ranger-docker/.env 3f795abde
dev-support/ranger-docker/docker-compose.ranger-postgres-mounted.yml PRE-CREATION
dev-support/ranger-docker/postgres-db /readme.pages PRE-CREATION
ranger_in_docker 2057bde3e
Diff: https://reviews.apache.org/r/74431/diff/3/
Changes: https://reviews.apache.org/r/74431/diff/2-3/
Testing
-------
tested and verified in UI. mounted db changes are visible
Thanks,
Mohit Ambalkar
Re: Review Request 74431: Add flag based support for mounting db volume in dev-support scripts
Posted by Mohit Ambalkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74431/
-----------------------------------------------------------
(Updated May 11, 2023, 1:12 p.m.)
Review request for ranger and Jai Patel.
Repository: ranger
Description
-------
Currently, the DB which gets used via dev-support scripts is not mounted to any local storage. As a result, we lose all data if docker containers are shutdown and brought up again.
Raising this ticket to have a flag based support for mounting the db volumes.
Diffs (updated)
-----
dev-support/ranger-docker/.env 3f795abde
dev-support/ranger-docker/docker-compose.ranger-postgres-mounted.yml PRE-CREATION
ranger_in_docker 2057bde3e
Diff: https://reviews.apache.org/r/74431/diff/2/
Changes: https://reviews.apache.org/r/74431/diff/1-2/
Testing
-------
tested and verified in UI. mounted db changes are visible
Thanks,
Mohit Ambalkar