[GitHub] [pulsar] zhaohaidao commented on a diff in pull request #18179: [fix][broker] Log pulsar service config except sensitive info at startup

[GitBox <gi...@apache.org>]

zhaohaidao commented on code in PR #18179:
URL: https://github.com/apache/pulsar/pull/18179#discussion_r1004409393


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2487,7 +2488,7 @@ The delayed message index bucket time step(in seconds) in per bucket snapshot se
     )
     private List<String> bootstrapNamespaces = new ArrayList<String>();
 
-    @ToString.Exclude

Review Comment:
   The current implementation uses ReflectionToStringBuilder to print the serialized result. If I understand correctly, ReflectionToStringBuilder.toString(config) does not recognize lombok's annotations, we need to use the corresponding annotations to filter privacy information, namely StringToExclude instead of lombok's String.ToExclude
   
   > ... Alternatively the ToStringExclude annotation can be used to exclude fields from being incorporated in the result. ... public class ReflectionToStringBuilder extends ToStringBuilder { ...
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org