You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "PickBas (via GitHub)" <gi...@apache.org> on 2023/05/13 17:09:10 UTC
[GitHub] [eventmesh] PickBas opened a new pull request, #3923: [ISSUE #3909] Replaced anonymous new ChannelFutureListener() with lambda
PickBas opened a new pull request, #3923:
URL: https://github.com/apache/eventmesh/pull/3923
Fixes #3909.
### Modifications
Replaced anonymous new ChannelFutureListener() with lambda.
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3923: [ISSUE #3909] Replaced anonymous new ChannelFutureListener() with lambda
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3923:
URL: https://github.com/apache/eventmesh/pull/3923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3923: [ISSUE #3909] Replaced anonymous new ChannelFutureListener() with lambda
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3923:
URL: https://github.com/apache/eventmesh/pull/3923#issuecomment-1548916289
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3923](https://app.codecov.io/gh/apache/eventmesh/pull/3923?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6b4aeff) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/ef917b9c5ae198bec3f2ebbf777fa75687803808?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ef917b9) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 6b4aeff differs from pull request most recent head 3bee359. Consider uploading reports for the commit 3bee359 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3923 +/- ##
============================================
- Coverage 13.93% 13.91% -0.03%
+ Complexity 1291 1290 -1
============================================
Files 571 571
Lines 28803 28797 -6
Branches 2807 2805 -2
============================================
- Hits 4015 4007 -8
+ Misses 24413 24412 -1
- Partials 375 378 +3
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../protocol/tcp/client/task/MessageTransferTask.java](https://app.codecov.io/gh/apache/eventmesh/pull/3923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL01lc3NhZ2VUcmFuc2ZlclRhc2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3923/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] PickBas commented on pull request #3923: [ISSUE #3909] Replaced anonymous new ChannelFutureListener() with lambda
Posted by "PickBas (via GitHub)" <gi...@apache.org>.
PickBas commented on PR #3923:
URL: https://github.com/apache/eventmesh/pull/3923#issuecomment-1556181885
Fixed merge conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] PickBas commented on pull request #3923: [ISSUE #3909] Replaced anonymous new ChannelFutureListener() with lambda
Posted by "PickBas (via GitHub)" <gi...@apache.org>.
PickBas commented on PR #3923:
URL: https://github.com/apache/eventmesh/pull/3923#issuecomment-1547501371
@Alonexc Fixed, have a look please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3923: [ISSUE #3909] Replaced anonymous new ChannelFutureListener() with lambda
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3923:
URL: https://github.com/apache/eventmesh/pull/3923#issuecomment-1547280622
please check the checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org