You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by bhuvnesh chaudhary <bc...@pivotal.io> on 2016/01/12 02:08:53 UTC
Review Request 42173: Update hawq configs to remove
hawq_standby_address_host on single node clusters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42173/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Sumit Mohanty.
Bugs: AMBARI-14599
https://issues.apache.org/jira/browse/AMBARI-14599
Repository: ambari
Description
-------
Update hawq configs to remove hawq_standby_address_host on single node clusters.
Currently, its available by default in templates, so is picked up by UI and is pushed to the filesystem during installation. On single node cluster, this property is not required to be displayed on UI and should not be pushed to filesystem.
Diffs
-----
ambari-web/app/controllers/wizard/step7_controller.js 42b5b87
ambari-web/test/controllers/wizard/step7_test.js a6a5fab
Diff: https://reviews.apache.org/r/42173/diff/
Testing
-------
yes.
22965 tests complete (19 seconds)
163 tests pending
[INFO] BUILD SUCCESS
Thanks,
bhuvnesh chaudhary
Re: Review Request 42173: Update hawq configs to remove
hawq_standby_address_host on single node clusters
Posted by jun aoki <ju...@gmail.com>.
> On Jan. 12, 2016, 7:49 p.m., Jayush Luniya wrote:
> > @Jaimin can you review these changes?
>
> bhuvnesh chaudhary wrote:
> @Jaimin/Richard Z. - Please let me know for any comments so that we can get it fixed, we are planning to push it to 2.2 as it blocks single node deploy. Thank you.
@jayush, we've waited more than a day and haven't heard anything back. We will go ahead and commit it.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42173/#review114049
-----------------------------------------------------------
On Jan. 12, 2016, 1:08 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42173/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 1:08 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14599
> https://issues.apache.org/jira/browse/AMBARI-14599
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update hawq configs to remove hawq_standby_address_host on single node clusters.
> Currently, its available by default in templates, so is picked up by UI and is pushed to the filesystem during installation. On single node cluster, this property is not required to be displayed on UI and should not be pushed to filesystem.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step7_controller.js 42b5b87
> ambari-web/test/controllers/wizard/step7_test.js a6a5fab
>
> Diff: https://reviews.apache.org/r/42173/diff/
>
>
> Testing
> -------
>
> yes.
> 22965 tests complete (19 seconds)
> 163 tests pending
>
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 42173: Update hawq configs to remove
hawq_standby_address_host on single node clusters
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
> On Jan. 12, 2016, 7:49 p.m., Jayush Luniya wrote:
> > @Jaimin can you review these changes?
@Jaimin/Richard Z. - Please let me know for any comments so that we can get it fixed, we are planning to push it to 2.2 as it blocks single node deploy. Thank you.
- bhuvnesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42173/#review114049
-----------------------------------------------------------
On Jan. 12, 2016, 1:08 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42173/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 1:08 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14599
> https://issues.apache.org/jira/browse/AMBARI-14599
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update hawq configs to remove hawq_standby_address_host on single node clusters.
> Currently, its available by default in templates, so is picked up by UI and is pushed to the filesystem during installation. On single node cluster, this property is not required to be displayed on UI and should not be pushed to filesystem.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step7_controller.js 42b5b87
> ambari-web/test/controllers/wizard/step7_test.js a6a5fab
>
> Diff: https://reviews.apache.org/r/42173/diff/
>
>
> Testing
> -------
>
> yes.
> 22965 tests complete (19 seconds)
> 163 tests pending
>
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 42173: Update hawq configs to remove
hawq_standby_address_host on single node clusters
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42173/#review114049
-----------------------------------------------------------
@Jaimin can you review these changes?
- Jayush Luniya
On Jan. 12, 2016, 1:08 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42173/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 1:08 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14599
> https://issues.apache.org/jira/browse/AMBARI-14599
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update hawq configs to remove hawq_standby_address_host on single node clusters.
> Currently, its available by default in templates, so is picked up by UI and is pushed to the filesystem during installation. On single node cluster, this property is not required to be displayed on UI and should not be pushed to filesystem.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step7_controller.js 42b5b87
> ambari-web/test/controllers/wizard/step7_test.js a6a5fab
>
> Diff: https://reviews.apache.org/r/42173/diff/
>
>
> Testing
> -------
>
> yes.
> 22965 tests complete (19 seconds)
> 163 tests pending
>
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 42173: Update hawq configs to remove
hawq_standby_address_host on single node clusters
Posted by Oleksandr Diachenko <od...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42173/#review114298
-----------------------------------------------------------
Ship it!
Ship It!
- Oleksandr Diachenko
On Jan. 12, 2016, 1:08 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42173/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 1:08 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14599
> https://issues.apache.org/jira/browse/AMBARI-14599
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update hawq configs to remove hawq_standby_address_host on single node clusters.
> Currently, its available by default in templates, so is picked up by UI and is pushed to the filesystem during installation. On single node cluster, this property is not required to be displayed on UI and should not be pushed to filesystem.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step7_controller.js 42b5b87
> ambari-web/test/controllers/wizard/step7_test.js a6a5fab
>
> Diff: https://reviews.apache.org/r/42173/diff/
>
>
> Testing
> -------
>
> yes.
> 22965 tests complete (19 seconds)
> 163 tests pending
>
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 42173: Update hawq configs to remove
hawq_standby_address_host on single node clusters
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42173/#review113968
-----------------------------------------------------------
ambari-web/test/controllers/wizard/step7_test.js (line 1172)
<https://reviews.apache.org/r/42173/#comment174751>
Please change this to the exact method you are testing, since you have refactored the method: removeHawqStandbyHostAddressConfig
- Matt
On Jan. 11, 2016, 5:08 p.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42173/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 5:08 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14599
> https://issues.apache.org/jira/browse/AMBARI-14599
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update hawq configs to remove hawq_standby_address_host on single node clusters.
> Currently, its available by default in templates, so is picked up by UI and is pushed to the filesystem during installation. On single node cluster, this property is not required to be displayed on UI and should not be pushed to filesystem.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step7_controller.js 42b5b87
> ambari-web/test/controllers/wizard/step7_test.js a6a5fab
>
> Diff: https://reviews.apache.org/r/42173/diff/
>
>
> Testing
> -------
>
> yes.
> 22965 tests complete (19 seconds)
> 163 tests pending
>
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>