You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hiroshi Ikeda (JIRA)" <ji...@apache.org> on 2016/04/15 07:35:25 UTC

[jira] [Updated] (HBASE-15292) Refined ZooKeeperWatcher to prevent ZooKeeper's callback while construction

     [ https://issues.apache.org/jira/browse/HBASE-15292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiroshi Ikeda updated HBASE-15292:
----------------------------------
    Attachment: HBASE-15292-V5.patch

Added a revised patch;
Refactored to suppress the findbug warning, and added some javadoc (I hope there are not so wrong sentences or words :)

> Refined ZooKeeperWatcher to prevent ZooKeeper's callback while construction
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-15292
>                 URL: https://issues.apache.org/jira/browse/HBASE-15292
>             Project: HBase
>          Issue Type: Bug
>          Components: Zookeeper
>            Reporter: Hiroshi Ikeda
>            Assignee: Hiroshi Ikeda
>            Priority: Minor
>         Attachments: HBASE-15292-V2.patch, HBASE-15292-V3.patch, HBASE-15292-V4.patch, HBASE-15292-V5.patch, HBASE-15292.patch
>
>
> The existing code is not just messy but also contains a subtle bug of visibility due to missing synchronization between threads.
> The root of the evil is that ZooKeeper uses a silly anti-pattern, starting a thread within its constructor, and in practice all the developers are not allowed to use ZooKeeper correctly without tedious code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)