You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dalaoqi (via GitHub)" <gi...@apache.org> on 2025/06/30 09:33:51 UTC
[PR] Remove threadNamePrefix parameter from ReplicaManager and ReplicaFetc… [kafka]
dalaoqi opened a new pull request, #20069:
URL: https://github.com/apache/kafka/pull/20069
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove threadNamePrefix parameter from ReplicaManager and ReplicaFetcherManager [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #20069:
URL: https://github.com/apache/kafka/pull/20069#discussion_r2175008570
##########
core/src/main/scala/kafka/server/ReplicaFetcherManager.scala:
##########
@@ -28,7 +28,6 @@ class ReplicaFetcherManager(brokerConfig: KafkaConfig,
protected val replicaManager: ReplicaManager,
metrics: Metrics,
time: Time,
- threadNamePrefix: Option[String] = None,
Review Comment:
You delete the `threadNamePrefix` from the constructor, but you don't update `ReplicaManagerBuilder` correspondingly. Hence, the build fails.
https://github.com/apache/kafka/blob/64aebb5621bd27ee9f2c4ab4506f32dcff267963/core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java#L112-L134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove threadNamePrefix parameter from ReplicaManager and ReplicaFetcherManager [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky merged PR #20069:
URL: https://github.com/apache/kafka/pull/20069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Remove threadNamePrefix parameter from ReplicaManager and ReplicaFetcherManager [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #20069:
URL: https://github.com/apache/kafka/pull/20069#discussion_r2175018091
##########
core/src/main/scala/kafka/server/ReplicaFetcherManager.scala:
##########
@@ -28,7 +28,6 @@ class ReplicaFetcherManager(brokerConfig: KafkaConfig,
protected val replicaManager: ReplicaManager,
metrics: Metrics,
time: Time,
- threadNamePrefix: Option[String] = None,
Review Comment:
`AbstractCoordinatorConcurrencyTest`
https://github.com/apache/kafka/blob/64aebb5621bd27ee9f2c4ab4506f32dcff267963/core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala#L194
##########
core/src/main/scala/kafka/server/ReplicaFetcherManager.scala:
##########
@@ -28,7 +28,6 @@ class ReplicaFetcherManager(brokerConfig: KafkaConfig,
protected val replicaManager: ReplicaManager,
metrics: Metrics,
time: Time,
- threadNamePrefix: Option[String] = None,
Review Comment:
`ReplicaManagerConcurrencyTest`
https://github.com/apache/kafka/blob/64aebb5621bd27ee9f2c4ab4506f32dcff267963/core/src/test/scala/unit/kafka/server/ReplicaManagerConcurrencyTest.scala#L203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org