You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2022/05/31 21:40:00 UTC
[jira] [Comment Edited] (CASSANDRA-17675) Revert the removal and deprecate withBufferSizeInMB(int size) in favor of the new withBufferSizeInMiB(int size)
[ https://issues.apache.org/jira/browse/CASSANDRA-17675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544621#comment-17544621 ]
Ekaterina Dimitrova edited comment on CASSANDRA-17675 at 5/31/22 9:39 PM:
--------------------------------------------------------------------------
[4.1&trunk patch PR|https://github.com/ekaterinadimitrova2/cassandra/pull/202] | [4.1 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=deprecate-old-names&filter=all] | [trunk CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=deprecate-trunk&filter=all]
Further to the fix I also updated the docs.
CI has only known failures where ticket exists.
[~maedhroz], [~dcapwell], [~mck], anyone of you up for a review?
was (Author: e.dimitrova):
[4.1&trunk patch PR|https://github.com/ekaterinadimitrova2/cassandra/pull/202] | [4.1 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=deprecate-old-names&filter=all] | [trunk CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=deprecate-trunk&filter=all]
CI has only known failures where ticket exists.
[~maedhroz], [~dcapwell], [~mck], anyone of you up for a review?
> Revert the removal and deprecate withBufferSizeInMB(int size) in favor of the new withBufferSizeInMiB(int size)
> ---------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17675
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17675
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/sstable
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> _withBufferSizeInMB(int size)_ was renamed in 4.1.
> The right way to do it was to deprecate it and add the new one withBufferSizeInMiB(int size)
> Add back _withBufferSizeInMB(int size)_
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org