[GitHub] [druid] somu-imply commented on a change in pull request #12335: Improve exception message for native binary operators

[GitBox <gi...@apache.org>]

somu-imply commented on a change in pull request #12335:
URL: https://github.com/apache/druid/pull/12335#discussion_r827364816



##########
File path: core/src/main/java/org/apache/druid/math/expr/BinaryOperatorExpr.java
##########
@@ -151,7 +152,11 @@ public ExprEval eval(ObjectBinding bindings)
 
   protected ExprEval evalString(@Nullable String left, @Nullable String right)
   {
-    throw new IllegalArgumentException("unsupported type " + ExprType.STRING);
+    throw new IAE("operator '%s' in expression (%s %s %s) is not supported on type of string.",

Review comment:
       Nit: we can just reframe as `"operator '%s' in expression (%s %s %s) is not supported on type 'string'`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org