You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/10/21 06:32:58 UTC
[GitHub] spark pull request #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__i...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/19546
[SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with grouping_id()
## What changes were proposed in this pull request?
Simplifies the test cases that were added in the PR https://github.com/apache/spark/pull/18270.
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark backportSPARK-21055
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19546.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19546
----
commit 35b07e2edc185213b1582d15e211e0d808c72333
Author: gatorsmile <ga...@gmail.com>
Date: 2017-10-21T06:30:23Z
fix.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19546
**[Test build #82943 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82943/testReport)** for PR 19546 at commit [`35b07e2`](https://github.com/apache/spark/commit/35b07e2edc185213b1582d15e211e0d808c72333).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19546
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82945/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19546
**[Test build #82945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82945/testReport)** for PR 19546 at commit [`35b07e2`](https://github.com/apache/spark/commit/35b07e2edc185213b1582d15e211e0d808c72333).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19546
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__i...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19546#discussion_r146108930
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala ---
@@ -1376,223 +1376,125 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils with TestHiveSingleton {
}
test("SPARK-8976 Wrong Result for Rollup #1") {
--- End diff --
Nit, do we need to keep `SPARK-21055` in the test case name here, too?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19546
**[Test build #82943 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82943/testReport)** for PR 19546 at commit [`35b07e2`](https://github.com/apache/spark/commit/35b07e2edc185213b1582d15e211e0d808c72333).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19546
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19546
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82943/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19546
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__i...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19546#discussion_r146110250
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala ---
@@ -1376,223 +1376,125 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils with TestHiveSingleton {
}
test("SPARK-8976 Wrong Result for Rollup #1") {
--- End diff --
That is fine. We do not have such a rule.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19546
cc @jiangxb1987 @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19546
Thanks! Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19546
**[Test build #82945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82945/testReport)** for PR 19546 at commit [`35b07e2`](https://github.com/apache/spark/commit/35b07e2edc185213b1582d15e211e0d808c72333).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19546: [SPARK-21055][SQL][FOLLOW-UP] replace grouping__id with ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19546
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org