You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nemo.apache.org by Joo Yeon Kim <jo...@apache.org> on 2018/12/02 03:10:57 UTC
[VOTE] Release Apache Nemo (Incubating) 0.1
Hello Nemo PPMC,
It is time for us to make the very first release!
This is a call for the vote to approve the release, 0.1.0.
Please refer to the information below to vote on this release, and vote:
[ ] +1 Release this package as Apache Nemo (incubating) 0.1.0
[ ] 0 I don't feel strongly about it, but the release seems okay.
[ ] -1 Please do not release this package because...
1. Source release files:
https://dist.apache.org/repos/dist/dev/incubator/nemo/0.1-incubating/
2. The release tag:
https://github.com/apache/incubator-nemo/releases/tag/nemo-release-0.1-rc1
3. The release hash:
https://github.com/apache/incubator-nemo/commit/0d3a7fae2d725e6ebc029cb5cbe3f2ed7358c46c
4. The Nexus Staging URL:
https://repository.apache.org/content/repositories/orgapachenemo-1001/
5. The KEYS file:
https://dist.apache.org/repos/dist/dev/incubator/nemo/KEYS
Best,
Joo Yeon
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by Jangho Seo <ja...@apache.org>.
Hi.
I'm happy to report that those changes were merged.
Cheers,
Jangho
On 12/10/18 2:08 PM, Joo Yeon Kim wrote:
> Hello, all.
>
> I've filed a PR to exclude the example jars from deployment over the
> weekend.
> (As mentioned earlier, I have firewall issues during the day time)
>
> Once this is merged, I'll send out a vote for the 2nd candidate.
>
> Thanks!
>
> Best,
> Joo Yeon
>
> On Thu, Dec 6, 2018 at 2:10 PM 송원욱 <wo...@apache.org> wrote:
>
>> +1 for source-only as well
>> Wonook
>>
>>
>> 2018년 12월 6일 (목) 오후 1:54, Jangho Seo <ja...@apache.org>님이 작성:
>>
>>> +1 for releasing source-only.
>>>
>>> Best,
>>> Jangho
>>>
>>> On 12/5/18 6:17 PM, Byung-Gon Chun wrote:
>>>> +1 for releasing only source code
>>>>
>>>> On Wed, Dec 5, 2018 at 6:01 PM Taegeon Um <ta...@gmail.com> wrote:
>>>>
>>>>> Thanks Joo Yeon!
>>>>>
>>>>>> On 3 Dec 2018, at 6:16 PM, Joo Yeon Kim <jo...@apache.org> wrote:
>>>>>>
>>>>>> Thank you mentors for the feedback and the vote!
>>>>>>
>>>>>> I've received a few requests to include the features merged to master
>>>>> after
>>>>>> rc1, if possible.
>>>>>> It looks like I'll be setting up another tarball as per Gon's request
>>>>>> anyway, so let's go ahead with another release candidate.
>>>>>> Apologies to Davor, Jean-Baptiste and Gon for the inconvenience, it
>>> looks
>>>>>> like we need to vote again :(
>>>>>>
>>>>>> Regarding the comments we received:
>>>>>> 1. I've filed a PR to check license headers, and it will be included
>> in
>>>>> rc2.
>>>>>> 2. @developers,
>>>>>> What are your opinions about Davor's comment?
>>>>>>
>>>>>>
>>>>> +1 for release source-only.
>>>>>
>>>>>>
>>>>>> *-> Examples produce shaded artifact, which bundles parts of Beam,
>>>>>> Spark.This bundling requires updates to license and notice files.
>> But,
>>>>>> thisshading process doesn't change what the main output JAR is, or
>> what
>>>>>> isbeing uploaded to Nexus. I'm not sure what's the value of releasing
>>>>>> binaryexamples when nobody should link against them. I'd guess you'd
>>> want
>>>>>> tochange this either to a Maven archetype or release source-only. *
>>>>>>
>>>>>> Best,
>>>>>> Joo Yeon
>>>>>>
>>>>>> On Mon, Dec 3, 2018 at 7:06 AM Byung-Gon Chun <bg...@gmail.com>
>>> wrote:
>>>>>>> +1 (binding)
>>>>>>>
>>>>>>> Great work! PGP and checksums look good.
>>>>>>> clean-install on Mac OS X/Java 1.8 works fine.
>>>>>>>
>>>>>>> Joo Yeon, one minor improvement to add.
>>>>>>> The files in the tarball contain ^M (extra CR) characters.
>>>>>>> I'm guessing you probably generated the tar ball on Windows.
>>>>>>>
>>>>>>> Best,
>>>>>>> Gon
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Dec 3, 2018 at 4:19 AM Jean-Baptiste Onofré <
>> jb@nanthrax.net>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> +1 (binding)
>>>>>>>>
>>>>>>>> Good work, I just did a quick review. As mentioned by Davor, there
>>> are
>>>>>>>> some minor improvements to do for the next release.
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> JB
>>>>>>>>
>>>>>>>> On 02/12/2018 19:40, Davor Bonaci wrote:
>>>>>>>>> +1 (binding)
>>>>>>>>>
>>>>>>>>> Great job!
>>>>>>>>>
>>>>>>>>> Things to improve, none of which I consider release-blocking:
>>>>>>>>>
>>>>>>>>> - Missing Apache header in a few files, mostly XML and like files.
>>> It
>>>>>>>> would
>>>>>>>>> be great to make all that part of checkstyle.
>>>>>>>>>
>>>>>>>>> - Examples produce shaded artifact, which bundles parts of Beam,
>>>>> Spark.
>>>>>>>>> This bundling requires updates to license and notice files. But,
>>> this
>>>>>>>>> shading process doesn't change what the main output JAR is, or
>> what
>>> is
>>>>>>>>> being uploaded to Nexus. I'm not sure what's the value of
>> releasing
>>>>>>>> binary
>>>>>>>>> examples when nobody should link against them. I'd guess you'd
>> want
>>> to
>>>>>>>>> change this either to a Maven archetype or release source-only.
>>>>>>>>>
>>>>>>>>> You can choose to address (or push back against) these for this
>>>>> release
>>>>>>>> or
>>>>>>>>> the next subsequent release. The first requires a new vote, so I
>>>>>>> wouldn't
>>>>>>>>> recommend fixing it now, unless there are other issues. Depending
>> on
>>>>>>> how
>>>>>>>>> you want to address the second one, you may be able to fix it
>> within
>>>>>>>> Nexus,
>>>>>>>>> without a new candidate/vote.
>>>>>>>>>
>>>>>>>>>> If this is incorrect/less-preferable, please let me know so that
>> I
>>>>> can
>>>>>>>>>>> upload a new tarball.
>>>>>>>>> No, leave this as is. It is perfect.
>>>>>>>>>
>>>>>>>>> * * *
>>>>>>>>>
>>>>>>>>> Overall, I'm thrilled to see this release going out. Thank you for
>>> the
>>>>>>>>> great work.
>>>>>>>>>
>>>>>>> --
>>>>>>> Byung-Gon Chun
>>>>>>>
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by Joo Yeon Kim <jo...@apache.org>.
Hello, all.
I've filed a PR to exclude the example jars from deployment over the
weekend.
(As mentioned earlier, I have firewall issues during the day time)
Once this is merged, I'll send out a vote for the 2nd candidate.
Thanks!
Best,
Joo Yeon
On Thu, Dec 6, 2018 at 2:10 PM 송원욱 <wo...@apache.org> wrote:
> +1 for source-only as well
> Wonook
>
>
> 2018년 12월 6일 (목) 오후 1:54, Jangho Seo <ja...@apache.org>님이 작성:
>
> > +1 for releasing source-only.
> >
> > Best,
> > Jangho
> >
> > On 12/5/18 6:17 PM, Byung-Gon Chun wrote:
> > > +1 for releasing only source code
> > >
> > > On Wed, Dec 5, 2018 at 6:01 PM Taegeon Um <ta...@gmail.com> wrote:
> > >
> > >> Thanks Joo Yeon!
> > >>
> > >>> On 3 Dec 2018, at 6:16 PM, Joo Yeon Kim <jo...@apache.org> wrote:
> > >>>
> > >>> Thank you mentors for the feedback and the vote!
> > >>>
> > >>> I've received a few requests to include the features merged to master
> > >> after
> > >>> rc1, if possible.
> > >>> It looks like I'll be setting up another tarball as per Gon's request
> > >>> anyway, so let's go ahead with another release candidate.
> > >>> Apologies to Davor, Jean-Baptiste and Gon for the inconvenience, it
> > looks
> > >>> like we need to vote again :(
> > >>>
> > >>> Regarding the comments we received:
> > >>> 1. I've filed a PR to check license headers, and it will be included
> in
> > >> rc2.
> > >>> 2. @developers,
> > >>> What are your opinions about Davor's comment?
> > >>>
> > >>>
> > >> +1 for release source-only.
> > >>
> > >>>
> > >>>
> > >>> *-> Examples produce shaded artifact, which bundles parts of Beam,
> > >>> Spark.This bundling requires updates to license and notice files.
> But,
> > >>> thisshading process doesn't change what the main output JAR is, or
> what
> > >>> isbeing uploaded to Nexus. I'm not sure what's the value of releasing
> > >>> binaryexamples when nobody should link against them. I'd guess you'd
> > want
> > >>> tochange this either to a Maven archetype or release source-only. *
> > >>>
> > >>> Best,
> > >>> Joo Yeon
> > >>>
> > >>> On Mon, Dec 3, 2018 at 7:06 AM Byung-Gon Chun <bg...@gmail.com>
> > wrote:
> > >>>
> > >>>> +1 (binding)
> > >>>>
> > >>>> Great work! PGP and checksums look good.
> > >>>> clean-install on Mac OS X/Java 1.8 works fine.
> > >>>>
> > >>>> Joo Yeon, one minor improvement to add.
> > >>>> The files in the tarball contain ^M (extra CR) characters.
> > >>>> I'm guessing you probably generated the tar ball on Windows.
> > >>>>
> > >>>> Best,
> > >>>> Gon
> > >>>>
> > >>>>
> > >>>> On Mon, Dec 3, 2018 at 4:19 AM Jean-Baptiste Onofré <
> jb@nanthrax.net>
> > >>>> wrote:
> > >>>>
> > >>>>> +1 (binding)
> > >>>>>
> > >>>>> Good work, I just did a quick review. As mentioned by Davor, there
> > are
> > >>>>> some minor improvements to do for the next release.
> > >>>>>
> > >>>>> Regards
> > >>>>> JB
> > >>>>>
> > >>>>> On 02/12/2018 19:40, Davor Bonaci wrote:
> > >>>>>> +1 (binding)
> > >>>>>>
> > >>>>>> Great job!
> > >>>>>>
> > >>>>>> Things to improve, none of which I consider release-blocking:
> > >>>>>>
> > >>>>>> - Missing Apache header in a few files, mostly XML and like files.
> > It
> > >>>>> would
> > >>>>>> be great to make all that part of checkstyle.
> > >>>>>>
> > >>>>>> - Examples produce shaded artifact, which bundles parts of Beam,
> > >> Spark.
> > >>>>>> This bundling requires updates to license and notice files. But,
> > this
> > >>>>>> shading process doesn't change what the main output JAR is, or
> what
> > is
> > >>>>>> being uploaded to Nexus. I'm not sure what's the value of
> releasing
> > >>>>> binary
> > >>>>>> examples when nobody should link against them. I'd guess you'd
> want
> > to
> > >>>>>> change this either to a Maven archetype or release source-only.
> > >>>>>>
> > >>>>>> You can choose to address (or push back against) these for this
> > >> release
> > >>>>> or
> > >>>>>> the next subsequent release. The first requires a new vote, so I
> > >>>> wouldn't
> > >>>>>> recommend fixing it now, unless there are other issues. Depending
> on
> > >>>> how
> > >>>>>> you want to address the second one, you may be able to fix it
> within
> > >>>>> Nexus,
> > >>>>>> without a new candidate/vote.
> > >>>>>>
> > >>>>>>> If this is incorrect/less-preferable, please let me know so that
> I
> > >> can
> > >>>>>>>> upload a new tarball.
> > >>>>>> No, leave this as is. It is perfect.
> > >>>>>>
> > >>>>>> * * *
> > >>>>>>
> > >>>>>> Overall, I'm thrilled to see this release going out. Thank you for
> > the
> > >>>>>> great work.
> > >>>>>>
> > >>>>
> > >>>> --
> > >>>> Byung-Gon Chun
> > >>>>
> > >>
> >
>
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by 송원욱 <wo...@apache.org>.
+1 for source-only as well
Wonook
2018년 12월 6일 (목) 오후 1:54, Jangho Seo <ja...@apache.org>님이 작성:
> +1 for releasing source-only.
>
> Best,
> Jangho
>
> On 12/5/18 6:17 PM, Byung-Gon Chun wrote:
> > +1 for releasing only source code
> >
> > On Wed, Dec 5, 2018 at 6:01 PM Taegeon Um <ta...@gmail.com> wrote:
> >
> >> Thanks Joo Yeon!
> >>
> >>> On 3 Dec 2018, at 6:16 PM, Joo Yeon Kim <jo...@apache.org> wrote:
> >>>
> >>> Thank you mentors for the feedback and the vote!
> >>>
> >>> I've received a few requests to include the features merged to master
> >> after
> >>> rc1, if possible.
> >>> It looks like I'll be setting up another tarball as per Gon's request
> >>> anyway, so let's go ahead with another release candidate.
> >>> Apologies to Davor, Jean-Baptiste and Gon for the inconvenience, it
> looks
> >>> like we need to vote again :(
> >>>
> >>> Regarding the comments we received:
> >>> 1. I've filed a PR to check license headers, and it will be included in
> >> rc2.
> >>> 2. @developers,
> >>> What are your opinions about Davor's comment?
> >>>
> >>>
> >> +1 for release source-only.
> >>
> >>>
> >>>
> >>> *-> Examples produce shaded artifact, which bundles parts of Beam,
> >>> Spark.This bundling requires updates to license and notice files. But,
> >>> thisshading process doesn't change what the main output JAR is, or what
> >>> isbeing uploaded to Nexus. I'm not sure what's the value of releasing
> >>> binaryexamples when nobody should link against them. I'd guess you'd
> want
> >>> tochange this either to a Maven archetype or release source-only. *
> >>>
> >>> Best,
> >>> Joo Yeon
> >>>
> >>> On Mon, Dec 3, 2018 at 7:06 AM Byung-Gon Chun <bg...@gmail.com>
> wrote:
> >>>
> >>>> +1 (binding)
> >>>>
> >>>> Great work! PGP and checksums look good.
> >>>> clean-install on Mac OS X/Java 1.8 works fine.
> >>>>
> >>>> Joo Yeon, one minor improvement to add.
> >>>> The files in the tarball contain ^M (extra CR) characters.
> >>>> I'm guessing you probably generated the tar ball on Windows.
> >>>>
> >>>> Best,
> >>>> Gon
> >>>>
> >>>>
> >>>> On Mon, Dec 3, 2018 at 4:19 AM Jean-Baptiste Onofré <jb...@nanthrax.net>
> >>>> wrote:
> >>>>
> >>>>> +1 (binding)
> >>>>>
> >>>>> Good work, I just did a quick review. As mentioned by Davor, there
> are
> >>>>> some minor improvements to do for the next release.
> >>>>>
> >>>>> Regards
> >>>>> JB
> >>>>>
> >>>>> On 02/12/2018 19:40, Davor Bonaci wrote:
> >>>>>> +1 (binding)
> >>>>>>
> >>>>>> Great job!
> >>>>>>
> >>>>>> Things to improve, none of which I consider release-blocking:
> >>>>>>
> >>>>>> - Missing Apache header in a few files, mostly XML and like files.
> It
> >>>>> would
> >>>>>> be great to make all that part of checkstyle.
> >>>>>>
> >>>>>> - Examples produce shaded artifact, which bundles parts of Beam,
> >> Spark.
> >>>>>> This bundling requires updates to license and notice files. But,
> this
> >>>>>> shading process doesn't change what the main output JAR is, or what
> is
> >>>>>> being uploaded to Nexus. I'm not sure what's the value of releasing
> >>>>> binary
> >>>>>> examples when nobody should link against them. I'd guess you'd want
> to
> >>>>>> change this either to a Maven archetype or release source-only.
> >>>>>>
> >>>>>> You can choose to address (or push back against) these for this
> >> release
> >>>>> or
> >>>>>> the next subsequent release. The first requires a new vote, so I
> >>>> wouldn't
> >>>>>> recommend fixing it now, unless there are other issues. Depending on
> >>>> how
> >>>>>> you want to address the second one, you may be able to fix it within
> >>>>> Nexus,
> >>>>>> without a new candidate/vote.
> >>>>>>
> >>>>>>> If this is incorrect/less-preferable, please let me know so that I
> >> can
> >>>>>>>> upload a new tarball.
> >>>>>> No, leave this as is. It is perfect.
> >>>>>>
> >>>>>> * * *
> >>>>>>
> >>>>>> Overall, I'm thrilled to see this release going out. Thank you for
> the
> >>>>>> great work.
> >>>>>>
> >>>>
> >>>> --
> >>>> Byung-Gon Chun
> >>>>
> >>
>
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by Jangho Seo <ja...@apache.org>.
+1 for releasing source-only.
Best,
Jangho
On 12/5/18 6:17 PM, Byung-Gon Chun wrote:
> +1 for releasing only source code
>
> On Wed, Dec 5, 2018 at 6:01 PM Taegeon Um <ta...@gmail.com> wrote:
>
>> Thanks Joo Yeon!
>>
>>> On 3 Dec 2018, at 6:16 PM, Joo Yeon Kim <jo...@apache.org> wrote:
>>>
>>> Thank you mentors for the feedback and the vote!
>>>
>>> I've received a few requests to include the features merged to master
>> after
>>> rc1, if possible.
>>> It looks like I'll be setting up another tarball as per Gon's request
>>> anyway, so let's go ahead with another release candidate.
>>> Apologies to Davor, Jean-Baptiste and Gon for the inconvenience, it looks
>>> like we need to vote again :(
>>>
>>> Regarding the comments we received:
>>> 1. I've filed a PR to check license headers, and it will be included in
>> rc2.
>>> 2. @developers,
>>> What are your opinions about Davor's comment?
>>>
>>>
>> +1 for release source-only.
>>
>>>
>>>
>>> *-> Examples produce shaded artifact, which bundles parts of Beam,
>>> Spark.This bundling requires updates to license and notice files. But,
>>> thisshading process doesn't change what the main output JAR is, or what
>>> isbeing uploaded to Nexus. I'm not sure what's the value of releasing
>>> binaryexamples when nobody should link against them. I'd guess you'd want
>>> tochange this either to a Maven archetype or release source-only. *
>>>
>>> Best,
>>> Joo Yeon
>>>
>>> On Mon, Dec 3, 2018 at 7:06 AM Byung-Gon Chun <bg...@gmail.com> wrote:
>>>
>>>> +1 (binding)
>>>>
>>>> Great work! PGP and checksums look good.
>>>> clean-install on Mac OS X/Java 1.8 works fine.
>>>>
>>>> Joo Yeon, one minor improvement to add.
>>>> The files in the tarball contain ^M (extra CR) characters.
>>>> I'm guessing you probably generated the tar ball on Windows.
>>>>
>>>> Best,
>>>> Gon
>>>>
>>>>
>>>> On Mon, Dec 3, 2018 at 4:19 AM Jean-Baptiste Onofré <jb...@nanthrax.net>
>>>> wrote:
>>>>
>>>>> +1 (binding)
>>>>>
>>>>> Good work, I just did a quick review. As mentioned by Davor, there are
>>>>> some minor improvements to do for the next release.
>>>>>
>>>>> Regards
>>>>> JB
>>>>>
>>>>> On 02/12/2018 19:40, Davor Bonaci wrote:
>>>>>> +1 (binding)
>>>>>>
>>>>>> Great job!
>>>>>>
>>>>>> Things to improve, none of which I consider release-blocking:
>>>>>>
>>>>>> - Missing Apache header in a few files, mostly XML and like files. It
>>>>> would
>>>>>> be great to make all that part of checkstyle.
>>>>>>
>>>>>> - Examples produce shaded artifact, which bundles parts of Beam,
>> Spark.
>>>>>> This bundling requires updates to license and notice files. But, this
>>>>>> shading process doesn't change what the main output JAR is, or what is
>>>>>> being uploaded to Nexus. I'm not sure what's the value of releasing
>>>>> binary
>>>>>> examples when nobody should link against them. I'd guess you'd want to
>>>>>> change this either to a Maven archetype or release source-only.
>>>>>>
>>>>>> You can choose to address (or push back against) these for this
>> release
>>>>> or
>>>>>> the next subsequent release. The first requires a new vote, so I
>>>> wouldn't
>>>>>> recommend fixing it now, unless there are other issues. Depending on
>>>> how
>>>>>> you want to address the second one, you may be able to fix it within
>>>>> Nexus,
>>>>>> without a new candidate/vote.
>>>>>>
>>>>>>> If this is incorrect/less-preferable, please let me know so that I
>> can
>>>>>>>> upload a new tarball.
>>>>>> No, leave this as is. It is perfect.
>>>>>>
>>>>>> * * *
>>>>>>
>>>>>> Overall, I'm thrilled to see this release going out. Thank you for the
>>>>>> great work.
>>>>>>
>>>>
>>>> --
>>>> Byung-Gon Chun
>>>>
>>
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by Byung-Gon Chun <bg...@gmail.com>.
+1 for releasing only source code
On Wed, Dec 5, 2018 at 6:01 PM Taegeon Um <ta...@gmail.com> wrote:
> Thanks Joo Yeon!
>
> > On 3 Dec 2018, at 6:16 PM, Joo Yeon Kim <jo...@apache.org> wrote:
> >
> > Thank you mentors for the feedback and the vote!
> >
> > I've received a few requests to include the features merged to master
> after
> > rc1, if possible.
> > It looks like I'll be setting up another tarball as per Gon's request
> > anyway, so let's go ahead with another release candidate.
> > Apologies to Davor, Jean-Baptiste and Gon for the inconvenience, it looks
> > like we need to vote again :(
> >
> > Regarding the comments we received:
> > 1. I've filed a PR to check license headers, and it will be included in
> rc2.
> > 2. @developers,
> > What are your opinions about Davor's comment?
> >
> >
>
> +1 for release source-only.
>
> >
> >
> >
> > *-> Examples produce shaded artifact, which bundles parts of Beam,
> > Spark.This bundling requires updates to license and notice files. But,
> > thisshading process doesn't change what the main output JAR is, or what
> > isbeing uploaded to Nexus. I'm not sure what's the value of releasing
> > binaryexamples when nobody should link against them. I'd guess you'd want
> > tochange this either to a Maven archetype or release source-only. *
> >
> > Best,
> > Joo Yeon
> >
> > On Mon, Dec 3, 2018 at 7:06 AM Byung-Gon Chun <bg...@gmail.com> wrote:
> >
> >> +1 (binding)
> >>
> >> Great work! PGP and checksums look good.
> >> clean-install on Mac OS X/Java 1.8 works fine.
> >>
> >> Joo Yeon, one minor improvement to add.
> >> The files in the tarball contain ^M (extra CR) characters.
> >> I'm guessing you probably generated the tar ball on Windows.
> >>
> >> Best,
> >> Gon
> >>
> >>
> >> On Mon, Dec 3, 2018 at 4:19 AM Jean-Baptiste Onofré <jb...@nanthrax.net>
> >> wrote:
> >>
> >>> +1 (binding)
> >>>
> >>> Good work, I just did a quick review. As mentioned by Davor, there are
> >>> some minor improvements to do for the next release.
> >>>
> >>> Regards
> >>> JB
> >>>
> >>> On 02/12/2018 19:40, Davor Bonaci wrote:
> >>>> +1 (binding)
> >>>>
> >>>> Great job!
> >>>>
> >>>> Things to improve, none of which I consider release-blocking:
> >>>>
> >>>> - Missing Apache header in a few files, mostly XML and like files. It
> >>> would
> >>>> be great to make all that part of checkstyle.
> >>>>
> >>>> - Examples produce shaded artifact, which bundles parts of Beam,
> Spark.
> >>>> This bundling requires updates to license and notice files. But, this
> >>>> shading process doesn't change what the main output JAR is, or what is
> >>>> being uploaded to Nexus. I'm not sure what's the value of releasing
> >>> binary
> >>>> examples when nobody should link against them. I'd guess you'd want to
> >>>> change this either to a Maven archetype or release source-only.
> >>>>
> >>>> You can choose to address (or push back against) these for this
> release
> >>> or
> >>>> the next subsequent release. The first requires a new vote, so I
> >> wouldn't
> >>>> recommend fixing it now, unless there are other issues. Depending on
> >> how
> >>>> you want to address the second one, you may be able to fix it within
> >>> Nexus,
> >>>> without a new candidate/vote.
> >>>>
> >>>>> If this is incorrect/less-preferable, please let me know so that I
> can
> >>>>>> upload a new tarball.
> >>>>>
> >>>>
> >>>> No, leave this as is. It is perfect.
> >>>>
> >>>> * * *
> >>>>
> >>>> Overall, I'm thrilled to see this release going out. Thank you for the
> >>>> great work.
> >>>>
> >>>
> >>
> >>
> >> --
> >> Byung-Gon Chun
> >>
>
>
--
Byung-Gon Chun
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by Taegeon Um <ta...@gmail.com>.
Thanks Joo Yeon!
> On 3 Dec 2018, at 6:16 PM, Joo Yeon Kim <jo...@apache.org> wrote:
>
> Thank you mentors for the feedback and the vote!
>
> I've received a few requests to include the features merged to master after
> rc1, if possible.
> It looks like I'll be setting up another tarball as per Gon's request
> anyway, so let's go ahead with another release candidate.
> Apologies to Davor, Jean-Baptiste and Gon for the inconvenience, it looks
> like we need to vote again :(
>
> Regarding the comments we received:
> 1. I've filed a PR to check license headers, and it will be included in rc2.
> 2. @developers,
> What are your opinions about Davor's comment?
>
>
+1 for release source-only.
>
>
>
> *-> Examples produce shaded artifact, which bundles parts of Beam,
> Spark.This bundling requires updates to license and notice files. But,
> thisshading process doesn't change what the main output JAR is, or what
> isbeing uploaded to Nexus. I'm not sure what's the value of releasing
> binaryexamples when nobody should link against them. I'd guess you'd want
> tochange this either to a Maven archetype or release source-only. *
>
> Best,
> Joo Yeon
>
> On Mon, Dec 3, 2018 at 7:06 AM Byung-Gon Chun <bg...@gmail.com> wrote:
>
>> +1 (binding)
>>
>> Great work! PGP and checksums look good.
>> clean-install on Mac OS X/Java 1.8 works fine.
>>
>> Joo Yeon, one minor improvement to add.
>> The files in the tarball contain ^M (extra CR) characters.
>> I'm guessing you probably generated the tar ball on Windows.
>>
>> Best,
>> Gon
>>
>>
>> On Mon, Dec 3, 2018 at 4:19 AM Jean-Baptiste Onofré <jb...@nanthrax.net>
>> wrote:
>>
>>> +1 (binding)
>>>
>>> Good work, I just did a quick review. As mentioned by Davor, there are
>>> some minor improvements to do for the next release.
>>>
>>> Regards
>>> JB
>>>
>>> On 02/12/2018 19:40, Davor Bonaci wrote:
>>>> +1 (binding)
>>>>
>>>> Great job!
>>>>
>>>> Things to improve, none of which I consider release-blocking:
>>>>
>>>> - Missing Apache header in a few files, mostly XML and like files. It
>>> would
>>>> be great to make all that part of checkstyle.
>>>>
>>>> - Examples produce shaded artifact, which bundles parts of Beam, Spark.
>>>> This bundling requires updates to license and notice files. But, this
>>>> shading process doesn't change what the main output JAR is, or what is
>>>> being uploaded to Nexus. I'm not sure what's the value of releasing
>>> binary
>>>> examples when nobody should link against them. I'd guess you'd want to
>>>> change this either to a Maven archetype or release source-only.
>>>>
>>>> You can choose to address (or push back against) these for this release
>>> or
>>>> the next subsequent release. The first requires a new vote, so I
>> wouldn't
>>>> recommend fixing it now, unless there are other issues. Depending on
>> how
>>>> you want to address the second one, you may be able to fix it within
>>> Nexus,
>>>> without a new candidate/vote.
>>>>
>>>>> If this is incorrect/less-preferable, please let me know so that I can
>>>>>> upload a new tarball.
>>>>>
>>>>
>>>> No, leave this as is. It is perfect.
>>>>
>>>> * * *
>>>>
>>>> Overall, I'm thrilled to see this release going out. Thank you for the
>>>> great work.
>>>>
>>>
>>
>>
>> --
>> Byung-Gon Chun
>>
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by Joo Yeon Kim <jo...@apache.org>.
Thank you mentors for the feedback and the vote!
I've received a few requests to include the features merged to master after
rc1, if possible.
It looks like I'll be setting up another tarball as per Gon's request
anyway, so let's go ahead with another release candidate.
Apologies to Davor, Jean-Baptiste and Gon for the inconvenience, it looks
like we need to vote again :(
Regarding the comments we received:
1. I've filed a PR to check license headers, and it will be included in rc2.
2. @developers,
What are your opinions about Davor's comment?
*-> Examples produce shaded artifact, which bundles parts of Beam,
Spark.This bundling requires updates to license and notice files. But,
thisshading process doesn't change what the main output JAR is, or what
isbeing uploaded to Nexus. I'm not sure what's the value of releasing
binaryexamples when nobody should link against them. I'd guess you'd want
tochange this either to a Maven archetype or release source-only. *
Best,
Joo Yeon
On Mon, Dec 3, 2018 at 7:06 AM Byung-Gon Chun <bg...@gmail.com> wrote:
> +1 (binding)
>
> Great work! PGP and checksums look good.
> clean-install on Mac OS X/Java 1.8 works fine.
>
> Joo Yeon, one minor improvement to add.
> The files in the tarball contain ^M (extra CR) characters.
> I'm guessing you probably generated the tar ball on Windows.
>
> Best,
> Gon
>
>
> On Mon, Dec 3, 2018 at 4:19 AM Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
>
> > +1 (binding)
> >
> > Good work, I just did a quick review. As mentioned by Davor, there are
> > some minor improvements to do for the next release.
> >
> > Regards
> > JB
> >
> > On 02/12/2018 19:40, Davor Bonaci wrote:
> > > +1 (binding)
> > >
> > > Great job!
> > >
> > > Things to improve, none of which I consider release-blocking:
> > >
> > > - Missing Apache header in a few files, mostly XML and like files. It
> > would
> > > be great to make all that part of checkstyle.
> > >
> > > - Examples produce shaded artifact, which bundles parts of Beam, Spark.
> > > This bundling requires updates to license and notice files. But, this
> > > shading process doesn't change what the main output JAR is, or what is
> > > being uploaded to Nexus. I'm not sure what's the value of releasing
> > binary
> > > examples when nobody should link against them. I'd guess you'd want to
> > > change this either to a Maven archetype or release source-only.
> > >
> > > You can choose to address (or push back against) these for this release
> > or
> > > the next subsequent release. The first requires a new vote, so I
> wouldn't
> > > recommend fixing it now, unless there are other issues. Depending on
> how
> > > you want to address the second one, you may be able to fix it within
> > Nexus,
> > > without a new candidate/vote.
> > >
> > >> If this is incorrect/less-preferable, please let me know so that I can
> > >>> upload a new tarball.
> > >>
> > >
> > > No, leave this as is. It is perfect.
> > >
> > > * * *
> > >
> > > Overall, I'm thrilled to see this release going out. Thank you for the
> > > great work.
> > >
> >
>
>
> --
> Byung-Gon Chun
>
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by Byung-Gon Chun <bg...@gmail.com>.
+1 (binding)
Great work! PGP and checksums look good.
clean-install on Mac OS X/Java 1.8 works fine.
Joo Yeon, one minor improvement to add.
The files in the tarball contain ^M (extra CR) characters.
I'm guessing you probably generated the tar ball on Windows.
Best,
Gon
On Mon, Dec 3, 2018 at 4:19 AM Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> +1 (binding)
>
> Good work, I just did a quick review. As mentioned by Davor, there are
> some minor improvements to do for the next release.
>
> Regards
> JB
>
> On 02/12/2018 19:40, Davor Bonaci wrote:
> > +1 (binding)
> >
> > Great job!
> >
> > Things to improve, none of which I consider release-blocking:
> >
> > - Missing Apache header in a few files, mostly XML and like files. It
> would
> > be great to make all that part of checkstyle.
> >
> > - Examples produce shaded artifact, which bundles parts of Beam, Spark.
> > This bundling requires updates to license and notice files. But, this
> > shading process doesn't change what the main output JAR is, or what is
> > being uploaded to Nexus. I'm not sure what's the value of releasing
> binary
> > examples when nobody should link against them. I'd guess you'd want to
> > change this either to a Maven archetype or release source-only.
> >
> > You can choose to address (or push back against) these for this release
> or
> > the next subsequent release. The first requires a new vote, so I wouldn't
> > recommend fixing it now, unless there are other issues. Depending on how
> > you want to address the second one, you may be able to fix it within
> Nexus,
> > without a new candidate/vote.
> >
> >> If this is incorrect/less-preferable, please let me know so that I can
> >>> upload a new tarball.
> >>
> >
> > No, leave this as is. It is perfect.
> >
> > * * *
> >
> > Overall, I'm thrilled to see this release going out. Thank you for the
> > great work.
> >
>
--
Byung-Gon Chun
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1 (binding)
Good work, I just did a quick review. As mentioned by Davor, there are
some minor improvements to do for the next release.
Regards
JB
On 02/12/2018 19:40, Davor Bonaci wrote:
> +1 (binding)
>
> Great job!
>
> Things to improve, none of which I consider release-blocking:
>
> - Missing Apache header in a few files, mostly XML and like files. It would
> be great to make all that part of checkstyle.
>
> - Examples produce shaded artifact, which bundles parts of Beam, Spark.
> This bundling requires updates to license and notice files. But, this
> shading process doesn't change what the main output JAR is, or what is
> being uploaded to Nexus. I'm not sure what's the value of releasing binary
> examples when nobody should link against them. I'd guess you'd want to
> change this either to a Maven archetype or release source-only.
>
> You can choose to address (or push back against) these for this release or
> the next subsequent release. The first requires a new vote, so I wouldn't
> recommend fixing it now, unless there are other issues. Depending on how
> you want to address the second one, you may be able to fix it within Nexus,
> without a new candidate/vote.
>
>> If this is incorrect/less-preferable, please let me know so that I can
>>> upload a new tarball.
>>
>
> No, leave this as is. It is perfect.
>
> * * *
>
> Overall, I'm thrilled to see this release going out. Thank you for the
> great work.
>
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by Davor Bonaci <da...@apache.org>.
+1 (binding)
Great job!
Things to improve, none of which I consider release-blocking:
- Missing Apache header in a few files, mostly XML and like files. It would
be great to make all that part of checkstyle.
- Examples produce shaded artifact, which bundles parts of Beam, Spark.
This bundling requires updates to license and notice files. But, this
shading process doesn't change what the main output JAR is, or what is
being uploaded to Nexus. I'm not sure what's the value of releasing binary
examples when nobody should link against them. I'd guess you'd want to
change this either to a Maven archetype or release source-only.
You can choose to address (or push back against) these for this release or
the next subsequent release. The first requires a new vote, so I wouldn't
recommend fixing it now, unless there are other issues. Depending on how
you want to address the second one, you may be able to fix it within Nexus,
without a new candidate/vote.
> If this is incorrect/less-preferable, please let me know so that I can
> > upload a new tarball.
>
No, leave this as is. It is perfect.
* * *
Overall, I'm thrilled to see this release going out. Thank you for the
great work.
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by Byung-Gon Chun <bg...@gmail.com>.
Thanks, Joo Yeon.
Mentors, could you check the tarball?
Thanks!
-Gon
On Sun, Dec 2, 2018 at 7:23 PM Joo Yeon Kim <jo...@apache.org> wrote:
> Hi Gon.
>
> I think the confusion is coming from a few missing files in the tarball
> compared to the commit hash in the git repository.
> I've created the source release tarball excluding a few files from our git
> repo, such as .git*, Travis CI file, etc, using options like
> '--exclude-vcs'.
> (A few other Apache projects seem to create source release files excluding
> such files too, please correct me if I'm wrong.)
>
> If this is incorrect/less-preferable, please let me know so that I can
> upload a new tarball.
> Please also let me know if the mismatch in the commit hash and the tarball
> you mentioned is not related to these missing files.
>
> Thanks,
> Joo Yeon
>
>
> On Sat, Dec 1, 2018 at 10:19 PM Byung-Gon Chun <bg...@gmail.com> wrote:
>
> > Hi Joo Yeon,
> >
> > Thanks for putting this together!
> >
> > Could you check again if the gzipped tarball file contains commit
> > 0d3a7fae2d725e6ebc029cb5cbe3f2ed7358c46c
> > <
> >
> https://github.com/apache/incubator-nemo/commit/0d3a7fae2d725e6ebc029cb5cbe3f2ed7358c46c
> > >
> > ?
> > I compared them, but I see that they are different. I may have done
> > something wrong.
> >
> > I'm following the process described here.
> >
> >
> https://cwiki.apache.org/confluence/display/TAVERNADEV/2016-03+Details%3A+How+to+Review+a+Release
> >
> > Thanks.
> > -Gon
> >
> >
> > On Sun, Dec 2, 2018 at 12:11 PM Joo Yeon Kim <jo...@apache.org> wrote:
> >
> > > Hello Nemo PPMC,
> > >
> > > It is time for us to make the very first release!
> > > This is a call for the vote to approve the release, 0.1.0.
> > >
> > > Please refer to the information below to vote on this release, and
> vote:
> > >
> > > [ ] +1 Release this package as Apache Nemo (incubating) 0.1.0
> > > [ ] 0 I don't feel strongly about it, but the release seems okay.
> > > [ ] -1 Please do not release this package because...
> > >
> > > 1. Source release files:
> > > https://dist.apache.org/repos/dist/dev/incubator/nemo/0.1-incubating/
> > >
> > > 2. The release tag:
> > >
> >
> https://github.com/apache/incubator-nemo/releases/tag/nemo-release-0.1-rc1
> > >
> > > 3. The release hash:
> > >
> > >
> >
> https://github.com/apache/incubator-nemo/commit/0d3a7fae2d725e6ebc029cb5cbe3f2ed7358c46c
> > >
> > > 4. The Nexus Staging URL:
> > > https://repository.apache.org/content/repositories/orgapachenemo-1001/
> > >
> > > 5. The KEYS file:
> > > https://dist.apache.org/repos/dist/dev/incubator/nemo/KEYS
> > >
> > >
> > > Best,
> > > Joo Yeon
> > >
> >
> >
> > --
> > Byung-Gon Chun
> >
>
--
Byung-Gon Chun
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by Joo Yeon Kim <jo...@apache.org>.
Hi Gon.
I think the confusion is coming from a few missing files in the tarball
compared to the commit hash in the git repository.
I've created the source release tarball excluding a few files from our git
repo, such as .git*, Travis CI file, etc, using options like
'--exclude-vcs'.
(A few other Apache projects seem to create source release files excluding
such files too, please correct me if I'm wrong.)
If this is incorrect/less-preferable, please let me know so that I can
upload a new tarball.
Please also let me know if the mismatch in the commit hash and the tarball
you mentioned is not related to these missing files.
Thanks,
Joo Yeon
On Sat, Dec 1, 2018 at 10:19 PM Byung-Gon Chun <bg...@gmail.com> wrote:
> Hi Joo Yeon,
>
> Thanks for putting this together!
>
> Could you check again if the gzipped tarball file contains commit
> 0d3a7fae2d725e6ebc029cb5cbe3f2ed7358c46c
> <
> https://github.com/apache/incubator-nemo/commit/0d3a7fae2d725e6ebc029cb5cbe3f2ed7358c46c
> >
> ?
> I compared them, but I see that they are different. I may have done
> something wrong.
>
> I'm following the process described here.
>
> https://cwiki.apache.org/confluence/display/TAVERNADEV/2016-03+Details%3A+How+to+Review+a+Release
>
> Thanks.
> -Gon
>
>
> On Sun, Dec 2, 2018 at 12:11 PM Joo Yeon Kim <jo...@apache.org> wrote:
>
> > Hello Nemo PPMC,
> >
> > It is time for us to make the very first release!
> > This is a call for the vote to approve the release, 0.1.0.
> >
> > Please refer to the information below to vote on this release, and vote:
> >
> > [ ] +1 Release this package as Apache Nemo (incubating) 0.1.0
> > [ ] 0 I don't feel strongly about it, but the release seems okay.
> > [ ] -1 Please do not release this package because...
> >
> > 1. Source release files:
> > https://dist.apache.org/repos/dist/dev/incubator/nemo/0.1-incubating/
> >
> > 2. The release tag:
> >
> https://github.com/apache/incubator-nemo/releases/tag/nemo-release-0.1-rc1
> >
> > 3. The release hash:
> >
> >
> https://github.com/apache/incubator-nemo/commit/0d3a7fae2d725e6ebc029cb5cbe3f2ed7358c46c
> >
> > 4. The Nexus Staging URL:
> > https://repository.apache.org/content/repositories/orgapachenemo-1001/
> >
> > 5. The KEYS file:
> > https://dist.apache.org/repos/dist/dev/incubator/nemo/KEYS
> >
> >
> > Best,
> > Joo Yeon
> >
>
>
> --
> Byung-Gon Chun
>
Re: [VOTE] Release Apache Nemo (Incubating) 0.1
Posted by Byung-Gon Chun <bg...@gmail.com>.
Hi Joo Yeon,
Thanks for putting this together!
Could you check again if the gzipped tarball file contains commit
0d3a7fae2d725e6ebc029cb5cbe3f2ed7358c46c
<https://github.com/apache/incubator-nemo/commit/0d3a7fae2d725e6ebc029cb5cbe3f2ed7358c46c>
?
I compared them, but I see that they are different. I may have done
something wrong.
I'm following the process described here.
https://cwiki.apache.org/confluence/display/TAVERNADEV/2016-03+Details%3A+How+to+Review+a+Release
Thanks.
-Gon
On Sun, Dec 2, 2018 at 12:11 PM Joo Yeon Kim <jo...@apache.org> wrote:
> Hello Nemo PPMC,
>
> It is time for us to make the very first release!
> This is a call for the vote to approve the release, 0.1.0.
>
> Please refer to the information below to vote on this release, and vote:
>
> [ ] +1 Release this package as Apache Nemo (incubating) 0.1.0
> [ ] 0 I don't feel strongly about it, but the release seems okay.
> [ ] -1 Please do not release this package because...
>
> 1. Source release files:
> https://dist.apache.org/repos/dist/dev/incubator/nemo/0.1-incubating/
>
> 2. The release tag:
> https://github.com/apache/incubator-nemo/releases/tag/nemo-release-0.1-rc1
>
> 3. The release hash:
>
> https://github.com/apache/incubator-nemo/commit/0d3a7fae2d725e6ebc029cb5cbe3f2ed7358c46c
>
> 4. The Nexus Staging URL:
> https://repository.apache.org/content/repositories/orgapachenemo-1001/
>
> 5. The KEYS file:
> https://dist.apache.org/repos/dist/dev/incubator/nemo/KEYS
>
>
> Best,
> Joo Yeon
>
--
Byung-Gon Chun