You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by he...@apache.org on 2018/10/16 18:48:48 UTC

svn commit: r1844042 - /spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm

Author: hege
Date: Tue Oct 16 18:48:48 2018
New Revision: 1844042

URL: http://svn.apache.org/viewvc?rev=1844042&view=rev
Log:
Some IP handling unifying

Modified:
    spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm?rev=1844042&r1=1844041&r2=1844042&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm Tue Oct 16 18:48:48 2018
@@ -1019,10 +1019,11 @@ sub complete_a_lookup {
 sub lookup_dnsbl_for_ip {
   my ($self, $pms, $obj, $ip) = @_;
 
-  local($1,$2,$3,$4);
-  $ip =~ /^(\d+)\.(\d+)\.(\d+)\.(\d+)$/
-    or warn "lookup_dnsbl_for_ip: not an IPv4 address: $ip\n";
-  my $revip = "$4.$3.$2.$1";
+  if ($ip !~ /^$IPV4_ADDRESS$/o) {
+    warn "lookup_dnsbl_for_ip: not an IPv4 address: $ip\n";
+    return;
+  }
+  my $revip = reverse_ip_address($ip);
 
   my $conf = $pms->{conf};
   my $tflags = $conf->{tflags};