You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "SkyeYoung (via GitHub)" <gi...@apache.org> on 2025/06/28 10:12:56 UTC
[PR] fix(credentials/detail): delete btn style [apisix-dashboard]
SkyeYoung opened a new pull request, #3132:
URL: https://github.com/apache/apisix-dashboard/pull/3132
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
|OLD|NEW|
|-|-|
|<img width="1511" alt="image" src="https://github.com/user-attachments/assets/4ab5730a-0b19-4d34-a388-900b22cef5ad" />|<img width="1511" alt="image" src="https://github.com/user-attachments/assets/da9d726f-2d73-4593-ba62-90861daa83fa" />|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(credentials/detail): delete btn style [apisix-dashboard]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3132:
URL: https://github.com/apache/apisix-dashboard/pull/3132#discussion_r2173194179
##########
src/routes/consumers/detail.$username/credentials/detail.$id.tsx:
##########
@@ -134,6 +134,7 @@ function RouteComponent() {
{t('form.btn.edit')}
</Button>
<DeleteResourceBtn
+ mode="detail"
Review Comment:
[nitpick] Consider using a predefined enum or constant for the `mode` prop instead of a raw string literal to avoid typos and centralize available modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(credentials/detail): delete btn style [apisix-dashboard]
Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan merged PR #3132:
URL: https://github.com/apache/apisix-dashboard/pull/3132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org