You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by le...@apache.org on 2009/11/19 08:09:22 UTC

svn commit: r882060 - /ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/TestRunContainer.java

Author: lektran
Date: Thu Nov 19 07:09:18 2009
New Revision: 882060

URL: http://svn.apache.org/viewvc?rev=882060&view=rev
Log:
When possible log the actual test case name, makes debugging a lot easier

Modified:
    ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/TestRunContainer.java

Modified: ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/TestRunContainer.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/TestRunContainer.java?rev=882060&r1=882059&r2=882060&view=diff
==============================================================================
--- ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/TestRunContainer.java (original)
+++ ofbiz/trunk/framework/testtools/src/org/ofbiz/testtools/TestRunContainer.java Thu Nov 19 07:09:18 2009
@@ -28,6 +28,7 @@
 import javolution.util.FastMap;
 import junit.framework.AssertionFailedError;
 import junit.framework.Test;
+import junit.framework.TestCase;
 import junit.framework.TestFailure;
 import junit.framework.TestListener;
 import junit.framework.TestResult;
@@ -214,19 +215,28 @@
     class JunitListener implements TestListener {
 
         public void addError(Test test, Throwable throwable) {
-            Debug.logWarning(throwable, "[JUNIT (error)] - " + test.getClass().getName() + " : " + throwable.toString(), module);
+            Debug.logWarning(throwable, "[JUNIT (error)] - " + getTestName(test) + " : " + throwable.toString(), module);
         }
 
         public void addFailure(Test test, AssertionFailedError assertionFailedError) {
-            Debug.logWarning("[JUNIT (failure)] - " + test.getClass().getName() + " : " + assertionFailedError.getMessage(), module);
+            Debug.logWarning("[JUNIT (failure)] - " + getTestName(test) + " : " + assertionFailedError.getMessage(), module);
         }
 
         public void endTest(Test test) {
-            //Debug.logInfo("[JUNIT] : " + test.getClass().getName() + " finished.", module);
+            Debug.logInfo("[JUNIT] : " + getTestName(test) + " finished.", module);
         }
 
         public void startTest(Test test) {
-           //Debug.logInfo("[JUNIT] : " + test.getClass().getName() + " starting...", module);
+           Debug.logInfo("[JUNIT] : " + getTestName(test) + " starting...", module);
+        }
+
+        private String getTestName(Test test) {
+            if (test instanceof TestCase) {
+                return ((TestCase)test).getName();
+            } else {
+                return test.getClass().getName();
+            }
+            
         }
     }
 }