You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/04/22 21:33:33 UTC

[PR] GH-41340: [C++][CMake][Windows] Remove needless .dll suffix from link libraries [arrow]

kou opened a new pull request, #41341:
URL: https://github.com/apache/arrow/pull/41341

   ### Rationale for this change
   
   We should use `.lib` (import library) not `.dll` for linking. So `.dll` is wrong. (But it seems working... Why...?)
   
   ### What changes are included in this PR?
   
   Remove `.dll` from link libraries because CMake generates suitable link options from library name automatically:
   
   https://cmake.org/cmake/help/latest/command/target_link_libraries.html#command:target_link_libraries
   
   > A plain library name: The generated link line will ask the linker to search for the library (e.g. `foo` becomes `-lfoo` or `foo.lib`).
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   Yes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41340: [C++][CMake][Windows] Remove needless .dll suffix from link libraries [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41341:
URL: https://github.com/apache/arrow/pull/41341#issuecomment-2076195019

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41340: [C++][CMake][Windows] Remove needless .dll suffix from link libraries [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41341:
URL: https://github.com/apache/arrow/pull/41341#issuecomment-2070990853

   :warning: GitHub issue #41340 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41340: [C++][CMake][Windows] Remove needless .dll suffix from link libraries [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #41341:
URL: https://github.com/apache/arrow/pull/41341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41340: [C++][CMake][Windows] Remove needless .dll suffix from link libraries [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41341:
URL: https://github.com/apache/arrow/pull/41341#issuecomment-2076405451

   After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 32885c91a1c94f1c8530815f4d4b8fc068859de8.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/24234947139) has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org