You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/02/26 06:03:36 UTC

[GitHub] [commons-collections] arturobernalg opened a new pull request #216: Checks if any value in the given Collections is null or empty.

arturobernalg opened a new pull request #216:
URL: https://github.com/apache/commons-collections/pull/216


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #216: Checks if any value in the given Collections is null or empty.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #216:
URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786435632


   
   [![Coverage Status](https://coveralls.io/builds/37471381/badge)](https://coveralls.io/builds/37471381)
   
   Coverage decreased (-0.03%) to 90.11% when pulling **372e8129e103ebf2800d5396517f78552c2a349a on arturobernalg:feature/isAnyEmpty** into **fdd78dc3e532ea8f60cbdce36dae0238362b5fef on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #216: Checks if any value in the given Collections is null or empty.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #216:
URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786435632


   
   [![Coverage Status](https://coveralls.io/builds/37470919/badge)](https://coveralls.io/builds/37470919)
   
   Coverage increased (+0.003%) to 90.139% when pulling **372e8129e103ebf2800d5396517f78552c2a349a on arturobernalg:feature/isAnyEmpty** into **fdd78dc3e532ea8f60cbdce36dae0238362b5fef on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] arturobernalg closed pull request #216: feature/COLLECTIONS-783 Checks if any value in the given Collections is null or empty.

Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #216:
URL: https://github.com/apache/commons-collections/pull/216


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] arturobernalg commented on pull request #216: feature/COLLECTIONS-783 Checks if any value in the given Collections is null or empty.

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #216:
URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786860741


   > Code looks OK. I think we just need to consider whether we want a new method for this, or if existing ways to use the code for this are better alternatives (easier maintenance having less methods).
   > 
   > ```java
   > List<String> l = Arrays.asList("a", "b", "c", "");
   > 
   > boolean b = CollectionUtils.containsAny(l, new Object[] { null, "" }); // or
   > boolean b = IterableUtils.matchesAny(l, (e) -> e == null || "".equals(e));
   > ```
   > 
   > This is similar to [lang]'s `isAnyEmpty`, but instead of a chain of characters, we check the array of objects. But probably we don't want a `isAnyBlank` (`" "` is blank, not empty).
   > 
   > And this one would need a JIRA issue @arturobernalg but we can wait for others to chime in and take a look at the new code first before creating one if you'd like.
   > 
   > Thanks for the PR's!
   > Bruno
   
   Hi @kinow 
   
   Jira created COLLECTIONS-783.
   
   I will check your comment and analyze what can we reuse and what will the  best alternative. Thank you very much 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls commented on pull request #216: Checks if any value in the given Collections is null or empty.

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #216:
URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786435632


   
   [![Coverage Status](https://coveralls.io/builds/37470677/badge)](https://coveralls.io/builds/37470677)
   
   Coverage decreased (-0.03%) to 90.11% when pulling **d02da08028963e8fb19d9135533b2437f063ce77 on arturobernalg:feature/isAnyEmpty** into **fdd78dc3e532ea8f60cbdce36dae0238362b5fef on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #216: Checks if any value in the given Collections is null or empty.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #216:
URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786435632


   
   [![Coverage Status](https://coveralls.io/builds/37470731/badge)](https://coveralls.io/builds/37470731)
   
   Coverage decreased (-0.03%) to 90.11% when pulling **d02da08028963e8fb19d9135533b2437f063ce77 on arturobernalg:feature/isAnyEmpty** into **fdd78dc3e532ea8f60cbdce36dae0238362b5fef on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] arturobernalg commented on pull request #216: feature/COLLECTIONS-783 Checks if any value in the given Collections is null or empty.

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #216:
URL: https://github.com/apache/commons-collections/pull/216#issuecomment-791883460


   HI @kinow 
   
   We can use `CollectionUtils.containsAny(collectionE, new Object[] { null, "" })`
   
   Close the PR
   
   TY


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls edited a comment on pull request #216: Checks if any value in the given Collections is null or empty.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #216:
URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786435632


   
   [![Coverage Status](https://coveralls.io/builds/37470719/badge)](https://coveralls.io/builds/37470719)
   
   Coverage increased (+0.003%) to 90.139% when pulling **d02da08028963e8fb19d9135533b2437f063ce77 on arturobernalg:feature/isAnyEmpty** into **fdd78dc3e532ea8f60cbdce36dae0238362b5fef on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] arturobernalg commented on pull request #216: feature/COLLECTIONS-783 Checks if any value in the given Collections is null or empty.

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #216:
URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786891734


   CollectionUtils.containsAny  check  bjects.requireNonNull and throw NPE. IMO this will  break the binary.  I keep checking `IterableUtils.matchesAny`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org