[GitHub] [arrow] westonpace commented on a diff in pull request #13108: ARROW-15415: [C++] Fixes for MSVC + vcpkg Debug build

[GitBox <gi...@apache.org>]

westonpace commented on code in PR #13108:
URL: https://github.com/apache/arrow/pull/13108#discussion_r894815051


##########
cpp/src/arrow/compute/exec/exec_plan.cc:
##########
@@ -46,7 +46,9 @@ namespace {
 struct ExecPlanImpl : public ExecPlan {
   explicit ExecPlanImpl(ExecContext* exec_context,
                         std::shared_ptr<const KeyValueMetadata> metadata = NULLPTR)
-      : ExecPlan(exec_context), metadata_(std::move(metadata)) {}
+      : ExecPlan(exec_context), metadata_(std::move(metadata)) {
+        span_ = arrow::internal::tracing::OTSpan();

Review Comment:
   How about something like this: https://github.com/westonpace/arrow/commit/85090cc7f8f3da02c1bccac124989b5243c89d97
   
   Then we can still use span but the details are hidden.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org