[jira] [Commented] (SOLR-14657) spurious ERRORs due to race condition between SolrIndexSearcher metrics and IndexReader closing

["Bence Szabó (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528590#comment-17528590 ] 

Bence Szabó commented on SOLR-14657:
------------------------------------

In one of my cases it seems like we are also hitting this problem and looking at the patch provided here, I am a bit concerned the returning impossible values would mess up the graphs our monitoring system creates based on the values returned by the metrics calls. 

Do you think a solution which includes resolving the race condition would be feasible?

I did a little investigation of the affected code and found that in the registerSearcher method we make use of the {{{}searcherLock{}}}, here: [https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/core/SolrCore.java#L2769] Do you recon we could somehow make use of this lock in the metrics call and this way resolve the race condition?

> spurious ERRORs due to race condition between SolrIndexSearcher metrics and IndexReader closing
> -----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-14657
>                 URL: https://issues.apache.org/jira/browse/SOLR-14657
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Chris M. Hostetter
>            Assignee: Chris M. Hostetter
>            Priority: Major
>             Fix For: 8.7, 9.0
>
>         Attachments: SOLR-14657.patch, SOLR-14657.patch
>
>
> I've seen situations in the wild where systems monitoring/polling metrics can trigger scary looking - but otherwise benign - ERRORs due to AlreadyClosedExceptions if/when the searcher/reader is in the process of being re-opened and the Gauge tries to call reader.numDocs(), etc...
> We should tweak the metrics logic to just ignore these exceptions



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org