You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "healchow (via GitHub)" <gi...@apache.org> on 2023/02/24 02:41:03 UTC

[GitHub] [inlong] healchow commented on a diff in pull request #7418: [INLONG-7417][Sort] Use SinkTableMetricData instead of SinkMetricData in IcebergSingleStreamWriter

healchow commented on code in PR #7418:
URL: https://github.com/apache/inlong/pull/7418#discussion_r1116443584


##########
inlong-sort/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/FlinkSink.java:
##########
@@ -716,7 +716,7 @@ static IcebergProcessOperator<RowData, WriteResult> createStreamWriter(Table tab
                         appendMode);
 
         return new IcebergProcessOperator<>(new IcebergSingleStreamWriter<>(
-                table.name(), taskWriterFactory, inlongMetric, auditHostAndPorts, null, dirtyOptions, dirtySink));
+                table.name(), taskWriterFactory,  null));

Review Comment:
   No need two blank before `null`.
   Please refer the https://github.com/apache/inlong/actions/runs/4250657643/jobs/7392028444, and fix the format violations, thanks. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org