[GitHub] spark pull request #17678: [SPARK-20381][SQL] Add SQL metrics of numOutputRo...

[ueshin <gi...@git.apache.org>]

Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17678#discussion_r114700907
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectAggregationIterator.scala ---
    @@ -83,6 +85,7 @@ class ObjectAggregationIterator(
     
       override final def next(): UnsafeRow = {
         val entry = aggBufferIterator.next()
    +    numOutputRows += 1
    --- End diff --
    
    This should be after the next line the same as the other `AggregationIterator`, just in case?
    
    ```scala
    val res = generateOutput(entry.groupingKey, entry.aggregationBuffer)
    numOutputRows += 1
    res
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org