You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/01/29 15:15:49 UTC
[GitHub] [incubator-daffodil] mbeckerle opened a new pull request #483: Enable 3 tests showing apostrophes work properly now in TDML
mbeckerle opened a new pull request #483:
URL: https://github.com/apache/incubator-daffodil/pull/483
Also many tests differing only by the test config had identical test names in the TDML.
These were modified so the ones that specify a config have a suffix added to their names.
DAFFODIL-1928, DAFFODIL-1420
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #483: Enable 3 tests showing apostrophes work properly now in TDML
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on a change in pull request #483:
URL: https://github.com/apache/incubator-daffodil/pull/483#discussion_r566926734
##########
File path: daffodil-test/src/test/scala/org/apache/daffodil/section00/general/TestFileBuffering.scala
##########
@@ -33,36 +33,36 @@ class TestUnparserFileBuffering {
import TestUnparserFileBuffering._
- @Test def test_puaInfosetChars_01(): Unit = { runner.runOneTest("puaInfosetChars_01") }
- @Test def test_puaInfosetChars_02(): Unit = { runner.runOneTest("puaInfosetChars_02") }
+ @Test def test_puaInfosetChars_01(): Unit = { runner.runOneTest("puaInfosetChars_01_ffb") }
Review comment:
Good idea. Will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] mbeckerle merged pull request #483: Enable 3 tests showing apostrophes work properly now in TDML
Posted by GitBox <gi...@apache.org>.
mbeckerle merged pull request #483:
URL: https://github.com/apache/incubator-daffodil/pull/483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] bsloane1650 commented on a change in pull request #483: Enable 3 tests showing apostrophes work properly now in TDML
Posted by GitBox <gi...@apache.org>.
bsloane1650 commented on a change in pull request #483:
URL: https://github.com/apache/incubator-daffodil/pull/483#discussion_r566910453
##########
File path: daffodil-test/src/test/scala/org/apache/daffodil/section00/general/TestFileBuffering.scala
##########
@@ -33,36 +33,36 @@ class TestUnparserFileBuffering {
import TestUnparserFileBuffering._
- @Test def test_puaInfosetChars_01(): Unit = { runner.runOneTest("puaInfosetChars_01") }
- @Test def test_puaInfosetChars_02(): Unit = { runner.runOneTest("puaInfosetChars_02") }
+ @Test def test_puaInfosetChars_01(): Unit = { runner.runOneTest("puaInfosetChars_01_ffb") }
Review comment:
Do we want to add the _ffb suffix to the JUnit testname as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org