You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/04 19:52:20 UTC

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31001: [SPARK-26399][CORE] Add new stage-level REST APIs and parameters to get stage level executor peak metrics distribution

AngersZhuuuu commented on a change in pull request #31001:
URL: https://github.com/apache/spark/pull/31001#discussion_r551532822



##########
File path: core/src/main/scala/org/apache/spark/status/api/v1/StagesResource.scala
##########
@@ -154,6 +154,29 @@ private[v1] class StagesResource extends BaseAppResource {
     }
   }
 
+  @GET
+  @Path("{stageId: \\d+}/{stageAttemptId: \\d+}/executorMetricsDistribution")
+  def executorSummary(
+      @PathParam("stageId") stageId: Int,
+      @PathParam("stageAttemptId") stageAttemptId: Int,
+      @DefaultValue("0.05,0.25,0.5,0.75,0.95")

Review comment:
       > change the default value to 0.0,0.25,0.5,0.75,1.0. In a parallel system, the duration of a stage is often determined by the slowest task/executor. To monitor/debug a skew issue, the maximal value (or 100% percentile value) is more useful than the 95% percentile value.
   
   Add this value since 
   https://github.com/apache/spark/blob/f54d430c536bfb4731401868960d6e35ddd089ea/core/src/main/scala/org/apache/spark/status/api/v1/StagesResource.scala#L72-L78
   
   Similar API need keep consistent too....




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org