[GitHub] [flink] sjwiesman commented on a change in pull request #10151: [FLINK-14231] Handle the pending processing-time timers to make endInput semantics on the operator chain strict

[GitBox <gi...@apache.org>]

sjwiesman commented on a change in pull request #10151: [FLINK-14231] Handle the pending processing-time timers to make endInput semantics on the operator chain strict
URL: https://github.com/apache/flink/pull/10151#discussion_r369739617
 
 

 ##########
 File path: flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/output/BoundedStreamTask.java
 ##########
 @@ -67,7 +67,7 @@
 	@Override
 	protected void init() throws Exception {
 		Preconditions.checkState(
-			operatorChain.getAllOperators().length == 1,
+			operatorChain.getNumberOfOperators() == 1,
 
 Review comment:
   Reiterating our offline conversation. BoundedStreamTask uses a NeverProcessingTimeService whose timers never fire so I don't believe this will be an issue in practice. It also cannot be chained and is only used internally within the state proc api. 
   
   https://github.com/apache/flink/blob/e1660b4b51b2a3c2fde7ff2c1f92bb0c329e602e/flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/output/BoundedStreamTask.java#L61

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services