You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/23 08:52:43 UTC

[GitHub] [flink] JingsongLi opened a new pull request #14474: [FLINK-20745][table] Clean useless codes: Never push calcProgram to correlate

JingsongLi opened a new pull request #14474:
URL: https://github.com/apache/flink/pull/14474


   
   ## What is the purpose of the change
   
   projectProgram in StreamPhysicalCorrelateBase never be used. we should remove the codes.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: (no
     - The runtime per-record code paths (performance sensitive): (no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no
     - The S3 file system connector: (no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi merged pull request #14474: [FLINK-20745][table] Clean useless codes: Never push calcProgram to correlate

Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #14474:
URL: https://github.com/apache/flink/pull/14474


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14474: [FLINK-20745][table] Clean useless codes: Never push calcProgram to correlate

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14474:
URL: https://github.com/apache/flink/pull/14474#issuecomment-750022452


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8de7643936b352afee9d94d47c8d44495cee5ec6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11231",
       "triggerID" : "8de7643936b352afee9d94d47c8d44495cee5ec6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3c918dc1e76d4ebec1609c5dc777b1e2259a9fac",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3c918dc1e76d4ebec1609c5dc777b1e2259a9fac",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8de7643936b352afee9d94d47c8d44495cee5ec6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11231) 
   * 3c918dc1e76d4ebec1609c5dc777b1e2259a9fac UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14474: [FLINK-20745][table] Clean useless codes: Never push calcProgram to correlate

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14474:
URL: https://github.com/apache/flink/pull/14474#issuecomment-750022452


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8de7643936b352afee9d94d47c8d44495cee5ec6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11231",
       "triggerID" : "8de7643936b352afee9d94d47c8d44495cee5ec6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3c918dc1e76d4ebec1609c5dc777b1e2259a9fac",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11247",
       "triggerID" : "3c918dc1e76d4ebec1609c5dc777b1e2259a9fac",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3c918dc1e76d4ebec1609c5dc777b1e2259a9fac Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11247) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14474: [FLINK-20745][table] Clean useless codes: Never push calcProgram to correlate

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14474:
URL: https://github.com/apache/flink/pull/14474#issuecomment-750022452


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8de7643936b352afee9d94d47c8d44495cee5ec6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11231",
       "triggerID" : "8de7643936b352afee9d94d47c8d44495cee5ec6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3c918dc1e76d4ebec1609c5dc777b1e2259a9fac",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11247",
       "triggerID" : "3c918dc1e76d4ebec1609c5dc777b1e2259a9fac",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8de7643936b352afee9d94d47c8d44495cee5ec6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11231) 
   * 3c918dc1e76d4ebec1609c5dc777b1e2259a9fac Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11247) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14474: [FLINK-20745][table] Clean useless codes: Never push calcProgram to correlate

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14474:
URL: https://github.com/apache/flink/pull/14474#issuecomment-750022452


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8de7643936b352afee9d94d47c8d44495cee5ec6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11231",
       "triggerID" : "8de7643936b352afee9d94d47c8d44495cee5ec6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8de7643936b352afee9d94d47c8d44495cee5ec6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11231) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe commented on a change in pull request #14474: [FLINK-20745][table] Clean useless codes: Never push calcProgram to correlate

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #14474:
URL: https://github.com/apache/flink/pull/14474#discussion_r548363042



##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/BatchPhysicalPythonCorrelateRule.java
##########
@@ -118,7 +118,6 @@ private BatchPhysicalPythonCorrelate convertToCorrelate(
 					convInput,
 					scan,
 					condition,
-					null,

Review comment:
       nit: please also remove unused imports




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14474: [FLINK-20745][table] Clean useless codes: Never push calcProgram to correlate

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14474:
URL: https://github.com/apache/flink/pull/14474#issuecomment-750022452


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8de7643936b352afee9d94d47c8d44495cee5ec6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8de7643936b352afee9d94d47c8d44495cee5ec6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8de7643936b352afee9d94d47c8d44495cee5ec6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14474: [FLINK-20745][table] Clean useless codes: Never push calcProgram to correlate

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14474:
URL: https://github.com/apache/flink/pull/14474#issuecomment-750018404


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 8de7643936b352afee9d94d47c8d44495cee5ec6 (Wed Dec 23 08:55:03 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org