You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2020/08/07 06:21:39 UTC
[GitHub] [incubator-tuweni] atoulme opened a new pull request #142: check license explicitly for this dependency
atoulme opened a new pull request #142:
URL: https://github.com/apache/incubator-tuweni/pull/142
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
## PR description
License checks failed on master for this dependency. Try resolving explicitly this dependency's license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #142: check license explicitly for this dependency
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #142:
URL: https://github.com/apache/incubator-tuweni/pull/142#issuecomment-670357005
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=h1) Report
> Merging [#142](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/77002de675755f3fcd59f5b584c8eb44222d4273&el=desc) will **decrease** coverage by `4.86%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #142 +/- ##
============================================
- Coverage 67.12% 62.25% -4.87%
+ Complexity 4290 3988 -302
============================================
Files 401 376 -25
Lines 19828 19448 -380
Branches 2440 2435 -5
============================================
- Hits 13309 12107 -1202
- Misses 5118 6045 +927
+ Partials 1401 1296 -105
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `?` | `?` | |
| #unit | `62.25% <ø> (+0.08%)` | `3988.00 <ø> (+4.00)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../rpc/mux/exceptions/RPCRequestFailedException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL211eC9leGNlcHRpb25zL1JQQ1JlcXVlc3RGYWlsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...c/main/kotlin/org/apache/tuweni/hobbits/Relayer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-aG9iYml0cy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvaG9iYml0cy9SZWxheWVyLmt0) | `0.00% <0.00%> (-96.43%)` | `0.00% <0.00%> (-8.00%)` | |
| [...tt/discovery/ScuttlebuttLocalDiscoveryService.java](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvZGlzY292ZXJ5L1NjdXR0bGVidXR0TG9jYWxEaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-82.54%)` | `0.00% <0.00%> (-18.00%)` | |
| [...tlin/org/apache/tuweni/ethclient/EthereumClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0V0aGVyZXVtQ2xpZW50Lmt0) | `0.00% <0.00%> (-80.77%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [78 more](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=footer). Last update [77002de...2377056](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #142: check license explicitly for this dependency
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #142:
URL: https://github.com/apache/incubator-tuweni/pull/142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #142: check license explicitly for this dependency
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #142:
URL: https://github.com/apache/incubator-tuweni/pull/142#issuecomment-670357005
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=h1) Report
> Merging [#142](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/77002de675755f3fcd59f5b584c8eb44222d4273&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #142 +/- ##
============================================
- Coverage 67.12% 67.03% -0.09%
+ Complexity 4290 4285 -5
============================================
Files 401 401
Lines 19828 19828
Branches 2440 2440
============================================
- Hits 13309 13292 -17
- Misses 5118 5142 +24
+ Partials 1401 1394 -7
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `46.62% <ø> (-2.46%)` | `610.00 <ø> (-15.00)` | |
| #unit | `62.25% <ø> (+0.08%)` | `3988.00 <ø> (+4.00)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/tuweni/net/coroutines/CoroutineSocketChannel.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZVNvY2tldENoYW5uZWwua3Q=) | `0.00% <0.00%> (-60.87%)` | `0.00% <0.00%> (-4.00%)` | |
| [...eni/net/coroutines/CoroutineServerSocketChannel.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZVNlcnZlclNvY2tldENoYW5uZWwua3Q=) | `44.44% <0.00%> (-55.56%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ache/tuweni/net/coroutines/CoroutineByteChannel.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZUJ5dGVDaGFubmVsLmt0) | `14.63% <0.00%> (-14.64%)` | `0.00% <0.00%> (ø%)` | |
| [...apache/tuweni/concurrent/coroutines/AsyncResult.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNSZXN1bHQua3Q=) | `79.24% <0.00%> (-5.67%)` | `0.00% <0.00%> (ø%)` | |
| [...che/tuweni/net/coroutines/CoroutineChannelGroup.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-bmV0LWNvcm91dGluZXMvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL25ldC9jb3JvdXRpbmVzL0Nvcm91dGluZUNoYW5uZWxHcm91cC5rdA==) | `63.15% <0.00%> (-3.51%)` | `0.00% <0.00%> (-1.00%)` | |
| [...org/apache/tuweni/devp2p/v5/DefaultUdpConnector.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGVmYXVsdFVkcENvbm5lY3Rvci5rdA==) | `88.33% <0.00%> (-0.84%)` | `36.00% <0.00%> (-1.00%)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.66% <0.00%> (-0.23%)` | `0.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/tuweni/crypto/sodium/Box.java](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9Cb3guamF2YQ==) | `54.04% <0.00%> (+0.86%)` | `26.00% <0.00%> (+2.00%)` | |
| [...ava/org/apache/tuweni/crypto/sodium/AES256GCM.java](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9BRVMyNTZHQ00uamF2YQ==) | `46.40% <0.00%> (+1.19%)` | `24.00% <0.00%> (+2.00%)` | |
| [...apache/tuweni/crypto/sodium/XChaCha20Poly1305.java](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9YQ2hhQ2hhMjBQb2x5MTMwNS5qYXZh) | `48.64% <0.00%> (+2.31%)` | `16.00% <0.00%> (ø%)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-tuweni/pull/142/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=footer). Last update [77002de...2377056](https://codecov.io/gh/apache/incubator-tuweni/pull/142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org